Opened 7 months ago
Last modified 7 months ago
#50507 new defect (bug)
The modal window is blank depending on the URL
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | minor | Version: | 5.4.2 |
Component: | External Libraries | Keywords: | has-patch |
Focuses: | ui, javascript | Cc: |
Description
Hi there,
I found that the function tb_parseQuery() can incorrectly parse some URLs that lead to incorrect displaying of modal windows: they are empty because of the undefined parameter "inlineId".
Sample URL:
https://test.localhost/wp-admin/index.php#TB_inline?inlineId=modal_123
tb_parseQuery() of this URL returns nothing.
Should be:
Object { page: "media#TB_inline", inlineId: "modal_123" }
The solution to the problem is to change this:
var Pairs = query.split(/[;&]/);
into this
var Pairs = query.split(/[;&?]/);
Not sure if this will not break something else, but it makes the Thickbox window work.
Attachments (1)
Change History (2)
Note: See
TracTickets for help on using
tickets.
Fix file