The modal window is blank depending on the URL

[madeinua]

Hi there,

I found that the function tb_parseQuery() can incorrectly parse some URLs that lead to incorrect displaying of modal windows: they are empty because of the undefined parameter "inlineId".

Sample URL:

​https://test.localhost/wp-admin/index.php#TB_inline?inlineId=modal_123

tb_parseQuery() of this URL returns nothing.

Should be:

Object { page: "media#TB_inline", inlineId: "modal_123" }

The solution to the problem is to change this:

var Pairs = query.split(/[;&]/);

into this

var Pairs = query.split(/[;&?]/);

Not sure if this will not break something else, but it makes the Thickbox window work.

[madeinua]

Fix file

[madeinua]

Sorry, the wrong URL is:

​https://test.localhost/wp-admin/options-general.php?page=media#TB_inline?inlineId=modal_123

Thanks!

[desrosj]

Hi @madeinua,

Sorry that this one took so long to receive a response.

I'm able to reproduce the issue with the URL you shared. However, I think this is happening because the URL is incorrect. There are two ?s in your URL. If you restructure the URL to use & for the two query vars, it works correctly.

In my testing, both of these work:

• https://test.localhost/wp-admin/options-general.php?page=media&inlineId=modal_123#TB_inline
• https://test.localhost/wp-admin/options-general.php#TB_inline?page=media&inlineId=modal_123

I'm going to close this out as a worksforme.