WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50521, comment 14


Ignore:
Timestamp:
09/14/2020 10:06:31 PM (5 years ago)
Author:
imath
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #50521, comment 14

    initial v1  
    11@dinhtungdu thanks for updating your PR.
    22
    3 I've just tested it and I confirm it work as expected. 50521.diff is a patch I made out of your PR. 50521.test.diff is the test checking the comments property of the comment's query is set with the array containing the object to override the db query.
     3I've just tested it and I confirm it works as expected. 50521.diff is a patch I made out of your PR. 50521.test.diff is the test checking the comments property of the comment's query is set with the array containing the object to override the db query.
    44
    55I've also tested it using the filter into WordPress admin. I believe like @adamsilverstein that this change shouldn't break anything for existing uses so we should be safe to add this in next release.