Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#50533 closed enhancement (fixed)

Different hover color on WordPress Version 5.4.2

Reported by: rkradadiya's profile rkradadiya Owned by:
Milestone: 5.7.1 Priority: normal
Severity: normal Version: 5.4.2
Component: Administration Keywords: good-first-bug has-patch 2nd-opinion
Focuses: ui, css, administration Cc:

Description

I found different colors on the theme search tab and Feature Filter hover.

Please check the attached screenshot.

Screenshot - https://www.screenpresso.com/=M27Gb

Attachments (1)

2020-07-02_15h28_52.png (101.4 KB) - added by rkradadiya 4 years ago.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
4 years ago

  • Focuses administration added

#2 @SergeyBiryukov
4 years ago

  • Keywords good-first-bug added; needs-design removed

Hi there, welcome back to WordPress Trac!

For reference, the background color on the Appearance item on the screenshot is #0073aa, while the color of the Feature Filter button is rgb(46, 162, 204), which translates to #2ea2cc.

At a glance, it seems like the Feature Filter button color should be updated to match the menu item color:

  • #0073aa appears to be the main highlighting color, per wp-admin/css/colors/_variables.scss.
  • rgb(46, 162, 204) is not used anywhere else except for that Feature Filter button.

This ticket was mentioned in Slack in #core by rkradadiya. View the logs.


4 years ago

#4 @afercia
4 years ago

I do remember this was a design choice, as the Filter button needs to be differentiated from the "Featured – Popular – Latest – Favorites" links (sic: they should be buttons).

However, it's maybe time to rethink the loog of the Filter button, as it is an exception in tue UI and doesn't help consistency.

#5 @rkradadiya
4 years ago

@afercia @SergeyBiryukov

Can I create patch for these?

Thanks

#6 @SergeyBiryukov
4 years ago

Sure, but as this is marked as needs-design-feedback, I'd suggest waiting for some feedback from the Design Team first :)

#7 @ryelle
4 years ago

  • Component changed from Themes to Administration

This ticket was mentioned in PR #451 on WordPress/wordpress-develop by killshot13.


4 years ago
#8

  • Keywords has-patch added; needs-patch removed

…or on WordPress Version 5.4.2

  • Changed background-color from rgb(46, 162, 204) to #0073aa on line 1142 of /wp-admin/css/common.css.

Trac ticket:
https://core.trac.wordpress.org/ticket/50533

This ticket was mentioned in Slack in #design by chaion07. View the logs.


3 years ago

This ticket was mentioned in Slack in #design by chaion07. View the logs.


3 years ago

#11 @estelaris
3 years ago

  • Keywords 2nd-opinion added; needs-design-feedback removed

Being this a bug from 5.4. and the various updates to the colorsin the UI we have, the design team wonders if this is still valid?

In either case, we are removing the "needs design feedback" label because we prefer to maintain the design decisions that have been made after 5.4.2

#12 @sabernhardt
3 years ago

  • Milestone changed from Awaiting Review to 5.7.1
  • Resolution set to fixed
  • Status changed from new to closed

The hover/focus color matches the admin menu blue background since 5.7.1 for the default color scheme:

  • [50025] updated the menu item background to #2271b1.
  • Then changeset 50687 switched the filter button hover color to the same blue for better contrast.

People might not expect that blue in other color schemes, but the reported issue is fixed.

killshot13 commented on PR #451:


3 years ago
#13

Created to resolve merge conflicts and bring my fork current with WordPress: master. The PR itself is no longer relevant, so the actual merge request should be disregarded.

Note: See TracTickets for help on using tickets.