WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 15 months ago

Last modified 15 months ago

#50555 closed defect (bug) (fixed)

Modern Color Scheme: Custom SVG icons in menu are invisible

Reported by: ryelle Owned by: desrosj
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.5
Component: Administration Keywords: has-patch
Focuses: css, administration Cc:

Description

Top-level admin menu pages can be registered with a custom SVG icon, base64-encoded. To work with the color schemes, this is automatically colored by svg-painter.js, using the colors passed as the last argument to wp_admin_css_color.

The new Modern scheme isn't setting these correctly, so the icons appear to be invisible. You can test this out with the demo plugin here. It registers an empty page that uses a custom SVG icon.

Attachments (2)

Screen Shot 2020-07-03 at 7.12.38 PM.png (9.9 KB) - added by ryelle 16 months ago.
Screen Shot 2020-07-03 at 7.12.42 PM.png (10.2 KB) - added by ryelle 16 months ago.

Download all attachments as: .zip

Change History (7)

This ticket was mentioned in PR #389 on WordPress/wordpress-develop by ryelle.


16 months ago

  • Keywords has-patch added

See ticket for before screenshots. After:

![Screen Shot 2020-07-03 at 7 30 20 PM](https://user-images.githubusercontent.com/541093/86501066-a4a65e80-bd63-11ea-8d17-a2cff0cac973.png)
![Screen Shot 2020-07-03 at 7 11 54 PM](https://user-images.githubusercontent.com/541093/86501068-a96b1280-bd63-11ea-97e9-9f6531f08398.png)

This also updates the color scheme preview to use the green color instead of the salmon color, since that ended up being removed from the scheme. Happy to remove that commit from this PR if it's not needed.

![Screen Shot 2020-07-03 at 7 13 01 PM](https://user-images.githubusercontent.com/541093/86501090-cef81c00-bd63-11ea-9b5b-d70230dc194b.png)

Trac ticket: https://core.trac.wordpress.org/ticket/50555

#2 @SergeyBiryukov
16 months ago

  • Milestone changed from Awaiting Review to 5.5

#3 @afercia
16 months ago

  • Version set to trunk

#4 @desrosj
15 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 48542:

Administration: Ensure SVG icons in admin menus are correctly colored.

Props ryelle.
Fixes #50555.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


15 months ago

Note: See TracTickets for help on using tickets.