WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#50562 closed enhancement (fixed)

REST API: Remove special-cased schema handling from themes controller

Reported by: timothyblynjacobs's profile TimothyBlynJacobs Owned by: timothyblynjacobs's profile TimothyBlynJacobs
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.4
Component: REST API Keywords: has-patch
Focuses: Cc:

Description

The themes controller has some ​special handling of multi-type schemas to work around the limitations of the REST API sanitizer.

Now that #50300 has been committed, we can remove this handling which will make this code more robust to 3rd party schemas.

Change History (2)

This ticket was mentioned in ​PR #390 on ​WordPress/wordpress-develop by ​TimothyBJacobs.
4 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/50562

#2 @TimothyBlynJacobs
4 years ago

  • Owner set to TimothyBlynJacobs
  • Resolution set to fixed
  • Status changed from new to closed

In 48308:

REST API: Remove specific multi-type schema handling from the themes controller.

Multi-type schema handling was improved in [48306]. In particular, it now allows for sanitizing a multi-typed value that wouldn't validate. Removing this handling will make 3rd party registered theme features more robust.

Fixes #50562.

Note: See TracTickets for help on using tickets.