Remove confusing upper case for option names on Edit Site: Settings screen

[SergeyBiryukov]

1. Go to Network Admin → All Sites.
2. Select a site, click "Edit".
3. Go to the Settings tab.

You'll see the list of option names displayed in a "readable" way:

• Users Can Register
• Admin Email
• Start Of Week

This is done via ucwords( str_replace( '_', ' ', $option->option_name ) ).

There are two problems with this:

• On non-English sites, it looks like some parts of the UI are not translated.
• It doesn't make sense for options like "Bp-xprofile-base-group-name".

It would be better to just display the original option names instead:

• users_can_register
• admin_email
• start_of_week

This would be consistent with the /wp-admin/options.php screen on single site.

[sabernhardt]

removes uppercase, adds code class and language, escapes HTML consistently

[sabernhardt]

The Siteurl capitalization does not make much sense either.

These labels would need the code class, and I think they might benefit from a language attribute.

[SergeyBiryukov]

Thanks for the patch!

Option names can technically be in any language (just tested with Cyrillic characters too), so I'm not sure the lang="en" attribute is appropriate. Otherwise, this looks good to me.

[sabernhardt]

removes uppercase, adds code class, escapes HTML consistently

[sabernhardt]

I'm not sure the lang="en" attribute is appropriate.

I removed the language.

[afrin29]

This report validates that the issue can be reproduced, and the indicated patch addresses the issue.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/50572/50572.1.diff
Environment
OS: macOS 12.5.1
Web Server: nginx/1.16.0
PHP: 7.4.1
WordPress: 6.2-alpha-55185
Browser: Chrome Version 108.0.5359.124
Theme: Twenty Twenty-Three
Active Plugins:
None

Actual Results
✅ Error condition occurs (reproduced).
✅ Issue resolved with this patch.
Additional Notes
Before Screenshot: ​https://d.pr/v/dJvc53
After Screenshot:Change Language(Bengeli) & Check: ​https://d.pr/v/VhT03V
On Default English Language: ​https://d.pr/i/HTRxMM

[afshanadiya]

This report validates, the issue can be reproduced and the indicated patch addresses the issue.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/50572/50572.1.diff

Environment

• OS: macOS 11.2.3
• Web Server: Nginx
• PHP: 7.4.30
• WordPress: 6.2-alpha-54642-src
• Browser: Chrome 109.0.5414.119
• Theme: Twenty Twenty-Three
• Active Plugins: No Plugins activated

Actual Results

✅ The error condition has been reproduced
✅ The Issue was resolved with this patch

Supplemental Artifacts

Before Screenshot: ​https://d.pr/i/wBKXnx
After Screenshot: ​https://d.pr/i/qbPygT

[johnbillion]

In 55408:

Networks and Sites: Remove confusing upper case for option names on Edit Site: Settings screen.

This type of transformation isn't always appropriate, especially for non-English language sites. Displaying the original option name makes it more clear what option is being changed.

Props SergeyBiryukov, sabernhardt, afrin29, afshanadiya

Fixes #50572