Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#50589 closed enhancement (fixed)

Update packages (GB 8.5)

Reported by: ellatrix's profile ellatrix Owned by: ellatrix's profile ellatrix
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

I ran the following:

npx wp-scripts packages-update

The following package versions were changed:
@wordpress/annotations: 1.19.0 -> 1.20.0
@wordpress/block-directory: 1.12.0 -> 1.13.0
@wordpress/block-editor: 4.2.0 -> 4.3.0
@wordpress/block-library: 2.21.0 -> 2.22.0
@wordpress/blocks: 6.19.0 -> 6.20.0
@wordpress/components: 9.9.0 -> 10.0.0
@wordpress/compose: 3.18.0 -> 3.19.0
@wordpress/core-data: 2.19.0 -> 2.20.0
@wordpress/data: 4.21.0 -> 4.22.0
@wordpress/data-controls: 1.15.0 -> 1.16.0
@wordpress/dom: 2.12.0 -> 2.13.0
@wordpress/e2e-test-utils: 4.10.0 -> 4.11.0
@wordpress/edit-post: 3.20.0 -> 3.21.0
@wordpress/editor: 9.19.0 -> 9.20.0
@wordpress/element: 2.15.0 -> 2.16.0
@wordpress/format-library: 1.21.0 -> 1.22.0
@wordpress/icons: 2.3.0 -> 2.4.0
@wordpress/keyboard-shortcuts: 1.8.0 -> 1.9.0
@wordpress/list-reusable-blocks: 1.20.0 -> 1.21.0
@wordpress/media-utils: 1.14.0 -> 1.15.0
@wordpress/notices: 2.7.0 -> 2.8.0
@wordpress/nux: 3.19.0 -> 3.20.0
@wordpress/plugins: 2.19.0 -> 2.20.0
@wordpress/primitives: 1.6.0 -> 1.7.0
@wordpress/rich-text: 3.19.0 -> 3.20.0
@wordpress/scripts: 12.0.0 -> 12.1.0
@wordpress/server-side-render: 1.15.0 -> 1.16.0
@wordpress/viewport: 2.20.0 -> 2.21.0

Change History (8)

This ticket was mentioned in PR #394 on WordPress/wordpress-develop by ellatrix.


4 years ago
#1

  • Keywords has-patch added

I ran the following:

`
npx wp-scripts packages-update
`

The following package versions were changed:
@wordpress/annotations: 1.19.0 -> 1.20.0
@wordpress/block-directory: 1.12.0 -> 1.13.0
@wordpress/block-editor: 4.2.0 -> 4.3.0
@wordpress/block-library: 2.21.0 -> 2.22.0
@wordpress/blocks: 6.19.0 -> 6.20.0
@wordpress/components: 9.9.0 -> 10.0.0
@wordpress/compose: 3.18.0 -> 3.19.0
@wordpress/core-data: 2.19.0 -> 2.20.0
@wordpress/data: 4.21.0 -> 4.22.0
@wordpress/data-controls: 1.15.0 -> 1.16.0
@wordpress/dom: 2.12.0 -> 2.13.0
@wordpress/e2e-test-utils: 4.10.0 -> 4.11.0
@wordpress/edit-post: 3.20.0 -> 3.21.0
@wordpress/editor: 9.19.0 -> 9.20.0
@wordpress/element: 2.15.0 -> 2.16.0
@wordpress/format-library: 1.21.0 -> 1.22.0
@wordpress/icons: 2.3.0 -> 2.4.0
@wordpress/keyboard-shortcuts: 1.8.0 -> 1.9.0
@wordpress/list-reusable-blocks: 1.20.0 -> 1.21.0
@wordpress/media-utils: 1.14.0 -> 1.15.0
@wordpress/notices: 2.7.0 -> 2.8.0
@wordpress/nux: 3.19.0 -> 3.20.0
@wordpress/plugins: 2.19.0 -> 2.20.0
@wordpress/primitives: 1.6.0 -> 1.7.0
@wordpress/rich-text: 3.19.0 -> 3.20.0
@wordpress/scripts: 12.0.0 -> 12.1.0
@wordpress/server-side-render: 1.15.0 -> 1.16.0
@wordpress/viewport: 2.20.0 -> 2.21.0

Trac ticket: https://core.trac.wordpress.org/ticket/50589

#2 @youknowriad
4 years ago

In my tests, the patch is looking good; I noticed when doing npm install && npm run build several changes to block.json files. I believe these should be included in the patch.

This ticket was mentioned in Slack in #core-editor by youknowriad. View the logs.


4 years ago

#4 @gziolo
4 years ago

Yes, I would expect to see changes in JSON and/or PHP files related to blocks, plus new versions generated to the assets file for modules. npm run build:dev should do the trick. Ideally, we package that into a new npm script for convenience:

diff --git a/package.json b/package.json
index 787b285eba..5d83f36633 100644
--- a/package.json
+++ b/package.json
@@ -162,6 +162,7 @@
                "env:cli": "node ./tools/local-env/scripts/docker.js run cli",
                "env:logs": "node ./tools/local-env/scripts/docker.js logs",
                "env:pull": "node ./tools/local-env/scripts/docker.js pull",
+               "packages-update": "wp-scripts packages-update && npm run build:dev",
                "test:php": "node ./tools/local-env/scripts/docker.js run --rm phpunit phpunit",
                "test:e2e": "node ./tests/e2e/run-tests.js"
        }

npm run build might work as well, but I'm not sure. We would have to test it first.

#5 @youknowriad
4 years ago

  • Keywords commit added

The updated patch is looking good.

#6 @ellatrix
4 years ago

  • Owner set to ellatrix
  • Resolution set to fixed
  • Status changed from new to closed

In 48379:

Editor: update packages

Fixes #50589.

#7 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.5

#8 @SergeyBiryukov
4 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.