WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 5 of Ticket #50592


Ignore:
Timestamp:
07/14/2020 10:58:55 AM (6 years ago)
Author:
swissspidy
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #50592

    • Property Status changed from new to reviewing
    • Property Summary changed from Confusing usage of home_url() to Sitemaps: Pass full paths to home_url()
    • Property Owner set to swissspidy
    • Property Milestone changed from Awaiting Review to 5.5
    • Property Keywords has-patch commit added

  • Ticket #50592 – Description

    initial v5  
    44See: https://github.com/WordPress/WordPress/blob/fe823d698f5e57135c102e02d7e23d4019ac59d5/wp-includes/sitemaps/class-wp-sitemaps-index.php#L78
    55
    6 There is no issue on a fresh install but it causes issues with plugins or themes using the filter `home_url`. Any function hooked to this filter will interpret that the url beeing built is the homepage url when it's actually the sitemap index url which is beeing built.
     6There is no issue on a fresh install but it causes issues with plugins or themes using the filter `home_url`. Any function hooked to this filter will interpret that the url being built is the homepage url when it's actually the sitemap index url which is being built.
    77
    88I propose to change this to: