Check requirements when uploading a plugin/theme by ZIP

[mariovalney]

From 9757 we agree uploading a plugin should check PHP required version.

We already check the package is a valid plugin and I think we can add both verifications: Requires PHP and Requires at least. And extend it to themes.

• Is there any other verifications that plugins from repository are submitted?
• Maybe we can use ​validate_plugin_requirements function.
• (@desrosj suggests) When the PHP or WordPress requirements are not met, can we link to the HelpHub so that the user has some direction: Maybe this page: ​https://wordpress.org/support/update-php/?

Add PHP/WP version validation to upload ZIP packages.
Support to theme and plugins.

Ticket: https://core.trac.wordpress.org/ticket/50593

[mariovalney]

Added a PR with validation to themes and plugins.
I'm using the same strings from 9757 to keep UX.

I guess we can improve this UI at least with the link do HelpHub like @desrosj suggested (wp_get_update_php_url / wp_get_default_update_php_url / wp_get_update_php_annotation).

Maybe keep version string in another line?

---

Here are prints for each case:

PHP Version for Plugin

WP Version for Theme

[SergeyBiryukov]

In 48666:

Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.

Props mariovalney, desrosj.
See #50593.

[SergeyBiryukov]

Replying to mariovalney:

(@desrosj suggests) When the PHP or WordPress requirements are not met, can we link to the HelpHub so that the user has some direction: Maybe this page: ​https://wordpress.org/support/update-php/?

Let's address this in 5.5.1.

[audrasjb]

Upgrade/Install: Link HelpHub documentation about PHP and WordPress upgrade after failed plugins and themes upgrade attempts

[audrasjb]

Added HelpHub links as per @SergeyBiryukov ’s previous comment.

[SergeyBiryukov]

48666.diff​ doesn't seem to work as expected in my testing:

• WP_Upgrader_Skin:error() runs the message through esc_html( strip_tags( ... ) ), so any links are stripped. That was likely added for a reason, so I'm not very comfortable with changing that in a minor release.
• I think the message should use the checks and functions used for similar messages elsewhere: current_user_can( 'update_php' ), wp_get_update_php_url(), wp_get_update_php_annotation().

Going to re-close this as fixed in 5.5. Created #51152 for addressing the remaining bits.