WordPress.org

Make WordPress Core

Changes between Version 3 and Version 4 of Ticket #50639, comment 11


Ignore:
Timestamp:
09/16/2020 03:05:59 AM (2 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50639, comment 11

    v3 v4  
    1 Looking at the media test failures, they appear to be caused by [https://github.com/WordPress/wpdev-docker-images/blob/84a4acfc15fd0bff04e3342e5c24a2c0ce5211cf/update.php#L181 missing 'gd' extension] in the [https://github.com/WordPress/wpdev-docker-images WP Docker image]. That includes tests explicitly checking for `imagejpeg()` and failing with "jpeg support unavailable", as well as tests implicitly relying on GD availability without specifically checking for it, causing more obscure failures. So consistently requiring GD functions where needed seems like the next step here.
     1Looking at the media test failures, they appear to be caused by [https://github.com/WordPress/wpdev-docker-images/blob/84a4acfc15fd0bff04e3342e5c24a2c0ce5211cf/update.php#L181 missing 'gd' extension] in the [https://github.com/WordPress/wpdev-docker-images WP Docker image]. That includes tests explicitly checking for `imagejpeg()` and failing with "jpeg support unavailable", as well as tests implicitly relying on GD availability without specifically checking for it, causing more obscure failures.
    22
    33The Docker image should probably be updated to provide the same list of extensions for PHP 8 that we currently have for PHP 7.4 and older: `gd`, `opcache`, `mysqli`, `zip`, `exif`, `intl`, `mbstring`, `xml`, `xsl`. If anyone is able to help with that and open a PR, please do :)
    44
    5 Still, explicitly requiring `imagejpeg()` and related functions as outlined in comment:3 would be better than the current obscure failures.
     5Still, explicitly requiring `imagejpeg()` and related functions as outlined in comment:3 would be better than the current obscure failures. So consistently requiring GD functions where needed seems like the next step here.