WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 4 months ago

#50645 closed defect (bug) (invalid)

Raw HTML displayed in snackbar message.

Reported by: spacedmonkey's profile spacedmonkey Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.5
Component: Media Keywords: close
Focuses: rest-api Cc:

Description

When editing an image with new cropping tools found in 5.5-beta1, a large image failed to edit. I was shown a snackbar message with raw html as text.

See attached image.

Attachments (1)

Screenshot 2020-07-13 at 10.57.09.png​ (919.2 KB) - added by spacedmonkey 3 years ago.
Weird error mesage.

Download all attachments as: .zip

Change History (6)

@spacedmonkey
3 years ago

Weird error mesage.

#1 @spacedmonkey
3 years ago

CC @azaozz

#2 @TimothyBlynJacobs
3 years ago

  • Keywords close added

I'm not sure what can be adjusted in Core here, this should be handled upstream in the Gutenberg UI code for image editing.

#3 @spacedmonkey
3 years ago

​Ticket on gutenberg repo.

#4 @azaozz
3 years ago

Yeah, this is the standard "server has crashed" error message coming from WP_Fatal_Error_Handler: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-fatal-error-handler.php#L182.

Wondering if it would make sense to put the help link URL and text in the WP_Error data instead of concatenating it with the error message. Then it can be rendered properly before displaying both through the API and direct output.

#5 @Mista-Flo
4 months ago

  • Keywords needs-patch removed
  • Resolution set to invalid
  • Status changed from new to closed

This was fixed in this Gutenberg PR ​https://github.com/WordPress/gutenberg/pull/40812

So we can close this one.

Note: See TracTickets for help on using tickets.