Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5065 closed enhancement (duplicate)

Unify User-Agent strings

Reported by: docwhat Owned by: jacobsantos
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: privacy user-agent
Focuses: Cc:


In WordPress 2.3, there are either 10 or 11 places where User-Agent strings are created.

I would like to suggest adding a function, wp_user_agent() which would generate the base User-Agent including things like PHP version and bloginfo('url'). It could optionally take an array (in hash form) to append extra values, like Akismet version, etc.

Example Usage:

$http_response .= "User-Agent: ".wp_user_agent(Array('Akismet' => '2.0'));

This would prevent repetition of code and allow for admins or plugin developers to add or remove information they are not comfortable sending out.


Attachments (3)

wp-user-agent-filtered.diff (5.4 KB) - added by Otto42 8 years ago.
Filtered patch
wp-user-agent.patch (6.1 KB) - added by docwhat 8 years ago.
Best version - includes filter and akismet changes.
wp-free-agent.php (925 bytes) - added by docwhat 8 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 @docwhat8 years ago

I have attached patch. I tried to follow the coding style as best as I could.

I changed the way the bloginfo('url') is appended to the user agent because id didn't follow RFC 2068. I put it in a comment (parenthesis) instead. I don't think that's an issue because according to photomatt, it isn't being used yet.


comment:2 @docwhat8 years ago

Also, my patch deliberately didn't change the Incutio and Snoopy UA strings, since they didn't seem to reflect anything. I don't actually understand when they are called, so I'm not sure what difference it makes.


comment:3 @docwhat8 years ago

Okay, I just updated the patch because I missed the magpie stuff. I'm not quite sure about the code that adds a trailing ')' to the user-agent, but I don't think the output would be changed in anyway.

My only other concern is that the define at the top may be called too early for the wp_user_agent() function to be available.


comment:4 @docwhat8 years ago

Added bug #5085, which is similar in spirit, though more complex.

comment:5 @docwhat8 years ago

Okay, this isn't complete.

It needs some sort of filter hook thingy. I'm not familiar with doing that. Can someone point me at an example or suggest a mechanism to do this?

Otherwise, you cannot write a plugin to disable or change it. :-/


comment:6 @Otto428 years ago

Attaching the same patch with a filter on wp_user_agent output.

@Otto428 years ago

Filtered patch

comment:7 @docwhat8 years ago

That was so easy. Neat! Thanks Otto42!

I thought the filter might have to be pre-registered or something.

I'm going to update the patch (mine) one more time to add the filter, and to add the missing akismet plugin patch (because that's needed too).

Then I'll attach the plugin to anonymize the ua.


@docwhat8 years ago

Best version - includes filter and akismet changes.

comment:8 @docwhat8 years ago


Now how do we get it approved and into the svn tree?


comment:9 @foolswisdom8 years ago

  • Keywords has-patch added
  • Milestone changed from 2.5 to 2.4

@docwhat8 years ago

comment:10 @f00f8 years ago

  • Milestone changed from 2.4 to 2.3.1


comment:11 @foolswisdom8 years ago

  • Milestone changed from 2.3.1 to 2.4

f00f, please don't change milestones. There is severe symptom that would justify putting this in a maint. release.

comment:12 @docwhat8 years ago


I've been running this patch (with the plugin) for over a month with no problems.


comment:13 @DD328 years ago

I'm thinking a better method might be to wrap all outgoing http requests into a WP function. Currently theres a fair few fsockopen() scattered around the place, and theres Snoopy too, What would be better is a function such as:

function wp_get_remote($url,$headers=false){
$userAgent = apply_filters('useragent',get_the_useragent());
return $html;
return array($html,$headers);

(Similar to wp_get_http_headers())

Just makes more sense than changing the user agents in all these different locations to me, Why change the code in so many places when it could all just be consolidated in one swoop?, It would also help in adding Global Proxy support in.

(Probably new ticket material, infact, i swear there is one, i just cant find it).

comment:14 @santosj8 years ago

Yeah. Maybe #4779 is what you were looking for DD32?

comment:15 @ffemtcj8 years ago

  • Milestone changed from 2.5 to 2.6

With the changes in 2.5 is this still valid?

comment:16 @jacobsantos7 years ago

  • Owner changed from anonymous to jacobsantos

comment:17 @jacobsantos7 years ago

  • Status changed from new to assigned

comment:18 @santosj7 years ago

  • Milestone 2.9 deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

This is mostly implemented in #4779. The API isn't used everywhere, but it eventually will be.

comment:19 @santosj7 years ago

  • Keywords has-patch removed
Note: See TracTickets for help on using tickets.