WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#50658 closed enhancement (fixed)

Sitemap: center the container

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: lowest
Severity: normal Version: 5.5
Component: Sitemaps Keywords: has-patch has-screenshots commit
Focuses: Cc:

Description

Following #50622, now that we have a container div, let's center the sitemap content.

See the attached screenshots and the patch.

Attachments (4)

50658-before.png​ (60.3 KB) - added by ramiy 3 years ago.
50658-after.png​ (61.6 KB) - added by ramiy 3 years ago.
50658.patch​ (525 bytes) - added by ramiy 3 years ago.
50658-after-rtl.png​ (61.9 KB) - added by ramiy 3 years ago.

Download all attachments as: .zip

Change History (16)

@ramiy
3 years ago

@ramiy
3 years ago

@ramiy
3 years ago

@ramiy
3 years ago

#1 @ramiy
3 years ago

  • Keywords has-patch has-screenshots added

This ticket was mentioned in ​Slack in #core-sitemaps by swissspidy. ​View the logs.
3 years ago

#3 @swissspidy
3 years ago

  • Milestone changed from Awaiting Review to 5.6
  • Type changed from defect (bug) to enhancement

#4 follow-up: @pacifika
3 years ago

Could you expand on the rationale for this change please?

This ticket was mentioned in ​Slack in #core by meaganhanes. ​View the logs.
3 years ago

#6 in reply to: ↑ 4 @ramiy
3 years ago

Replying to pacifika:

Could you expand on the rationale for this change please?

Because not only bots use xml-sitemaps, humans are checking them too. This is why we have a sitemaps stylesheet in the first place, to style the page for regular people. And like all content on the web consumed by humans, it should be visually centered. Or am I wrong?

This ticket was mentioned in ​Slack in #core-sitemaps by ramiy. ​View the logs.
3 years ago

This ticket was mentioned in ​Slack in #core by laura. ​View the logs.
3 years ago

#9 @hellofromTonya
3 years ago

5.6 Beta 1 is less than 2 weeks away. @swissspidy is this ticket on your radar to land in 5.6? If yes, what's the next step to move it forward?

#10 @johnbillion
3 years ago

  • Priority changed from normal to lowest
  • Version set to 5.5

#11 @swissspidy
3 years ago

  • Keywords commit added

The chosen max-width do seems a bit arbitrary, but overall this change probably doesn't make much of a difference. If anyone can commit it, feel free, but I am taking some time off until end of the month.

#12 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49221:

Sitemaps: Center the container for sitemap content.

Props ramiy, swissspidy.
Fixes #50658.

Note: See TracTickets for help on using tickets.