Block Editor: Missing styles for block directory

[ryelle]

It looks like the styles for the block directory aren't being loaded in the editor. They're correctly bundled into the dist file, but never enqueued.

[ryelle]

screenshot of current block directory result, missing styles

This adds the block directory styles as a dependency of the edit-post style.

Fixed screenshot:


Trac ticket: https://core.trac.wordpress.org/ticket/50661

Do we need to remove the manual enqueues from edit-form-blocks.php.

What's the reason for enqueueing in that file, instead of setting up dependencies in script-loader? If I were to follow the JS, I'd remove ​the dependency here, but I'm not sure which is the preferred method.

I'm not sure. Maybe @tellyworth knows?

It was just a silly oversight on my part while backporting, it wasn't intentional.

I've moved the enqueue calls to new function, wp_enqueue_block_editor_assets_block_directory, hooked into enqueue_block_editor_assets, so script & style are both added together now.

This also provides a method for disabling the block directory, by unhooking that function:

{{{php
add_action(

'plugins_loaded',
function() {

remove_action( 'enqueue_block_editor_assets', 'wp_enqueue_block_editor_assets_block_directory' );

}

);
}}}

See ​https://github.com/WordPress/gutenberg/issues/23961

[desrosj]

In 48537:

Editor: Ensure the required assets for the block directory are enqueued.

This fixes an issue where the block directory appears unstyled due to the stylesheets not being enqueued.

Props ryelle, timothyblynjacobs, earnjam.
Fixes #50661.

This was committed in https://core.trac.wordpress.org/changeset/48537. For reference, I went with a different function name, wp_enqueue_editor_block_directory_assets(). It read a bit more clear to me.