WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#5067 closed enhancement (worksforme)

Ensure Prototype is loaded before jQuery

Reported by: mdawaffe Owned by: westi
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3
Component: General Keywords: 2nd-opinion
Focuses: Cc:

Description

This is in line with WP's use of jQuery's noConflict system.

Attachments (1)

5067.diff (745 bytes) - added by mdawaffe 7 years ago.

Download all attachments as: .zip

Change History (11)

mdawaffe7 years ago

comment:1 ryan7 years ago

  • Milestone changed from 2.4 to 2.3.1

comment:2 ryan7 years ago

Nominating for 2.3.1 since some people have tripped over this. We've been running this on wordpress.com without problem.

comment:3 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6209]) Force prototype to load before jquery. Props mdawaffe. fixes #5067 for trunk

comment:4 ryan7 years ago

(In [6210]) Force prototype to load before jquery. Props mdawaffe. fixes #5067 for trunk

comment:5 ryan7 years ago

[6210] is for 2.3.

comment:6 follow-up: paulmjr6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

this change is causing segmentation errors on my system, can we investigate why/and/or fix it ?

more details in:
http://wordpress.org/support/topic/155883?replies=7

the fix for now is use script-loader.php from v 2.3

comment:7 lloydbudd6 years ago

  • Keywords has-patch removed
  • Milestone changed from 2.3.1 to 2.5

comment:8 in reply to: ↑ 6 ; follow-up: westi6 years ago

  • Owner changed from anonymous to westi
  • Status changed from reopened to new

Replying to paulmjr:

this change is causing segmentation errors on my system, can we investigate why/and/or fix it ?

more details in:
http://wordpress.org/support/topic/155883?replies=7

the fix for now is use script-loader.php from v 2.3

Looking at the info you have posted you have a php crash occurring.

Can you generate a backtrace for it?

http://bugs.php.net/bugs-generating-backtrace.php

comment:9 in reply to: ↑ 8 paulmjr6 years ago

Replying to westi:

Replying to paulmjr:

this change is causing segmentation errors on my system, can we investigate why/and/or fix it ?

more details in:
http://wordpress.org/support/topic/155883?replies=7

the fix for now is use script-loader.php from v 2.3

Looking at the info you have posted you have a php crash occurring.

Can you generate a backtrace for it?

http://bugs.php.net/bugs-generating-backtrace.php

I'll give that a go tonight and post the result, thanks for looking into it

comment:10 mdawaffe6 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

Worksforme. No feedback from reopener in over a month.

Note: See TracTickets for help on using tickets.