WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #50670, comment 1


Ignore:
Timestamp:
07/15/2020 11:22:42 PM (6 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #50670, comment 1

    v1 v2  
    11Seems to happen only for themes. Caused by `Theme_Upgrader` missing a conditional that is in `Plugin_Upgrader`. See https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-theme-upgrader.php#L97 and https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-plugin-upgrader.php#L89.
    22
    3 What would be the best fix here? Adding `ppublic $overwrite;` to `WP_Upgrader_Skin` or the conditional, or both? :)
     3What would be the best fix here? Adding `public $overwrite;` to `WP_Upgrader_Skin` or the conditional, or both? :)