WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#50676 closed defect (bug) (fixed)

Remove unsupported Hulu oembed provider

Reported by: talldanwp Owned by: desrosj
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

As mentioned in https://github.com/WordPress/gutenberg/issues/23920, Hulu no longer seems to support their oembed service.

It seems like the best option would be to drop Hulu support similar to previous unsupported providers in #45399.

Change History (8)

This ticket was mentioned in PR #412 on WordPress/wordpress-develop by tacitonic.


13 months ago

  • Keywords has-patch added; needs-patch removed

Added Hulu to 'no longer supported providers' from 'supported providers' list.

Fixes https://github.com/WordPress/gutenberg/issues/23920

Trac ticket: https://core.trac.wordpress.org/ticket/50676
---

#2 @tacitonic
13 months ago

@talldanwp let me know if there are any changes. Thanks!

#3 @desrosj
13 months ago

  • Milestone changed from Future Release to 5.5

I'm thinking this is a good bug to squash for 5.5. Moving into the milestone to explore.

It is removing a service that will no longer work as expected, and not adding or changing functionality in any way.

@talldanwp If we chose to remove oEmbed support for Hulu in 5.5, could the Hulu oEmbed block be disabled and backported?

#4 @talldanwp
13 months ago

Hey @desrosj, sounds good, it looks like the 'Backport to WP Core' label has been added to the merged pull request for removing the block (https://github.com/WordPress/gutenberg/pull/23984), so we should be good to go for landing both changes in 5.5.

#5 @desrosj
13 months ago

  • Keywords commit added
  • Owner set to desrosj
  • Status changed from new to assigned

#6 @desrosj
13 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48512:

Embeds: Remove Hulu from the list of supported oEmbed providers.

The oEmbed service for Hulu no longer works and appears to have been silently disabled.

Props tacitonic, talldanwp, youknowriad, bph.
Fixes #50676.

#7 @desrosj
13 months ago

In 48513:

Embeds: Correct the version number when Hulu was deprecated.

Follow up of [48512]
See #50676.

#8 @prbot
13 months ago

desrosj commented on PR #412:

Thanks for this, @tacitonic! This was merged into Core in https://core.trac.wordpress.org/changeset/48512.

Note: See TracTickets for help on using tickets.