Remove underline in Theme "Enable auto-updates".

[chetan200891]

In theme overlay there is underline in "Enable auto-updates". It should be removed to make it consistent with other.

[chetan200891]

Before

[chetan200891]

Initial patch.

[chetan200891]

After applying patch.

[sabernhardt]

removes underline without !important

[sabernhardt]

option to underline both author link and button text instead

[sabernhardt]

Thanks @chetan200891 !

50697.1.diff​ changes the selector so the !important is no longer necessary to remove the underline from the button (as intended when it was a link).

However, I highly recommend making it consistent the other way by underlining both the author link and the button text (without underlining the spinner icon). 50697.underline-author.diff​ clearly distinguishes the blue link from the gray text.

[afercia]

The underline shouldn't be removed. Otherwise, this link (actually it's a button that looks like a link) would be distinguishable as an interactive controls only by its color.

Color alone is not sufficient. As in the case of links, the underline is necessary when the context doesn't clarify it's an interactive control.

​https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/#links-underline-or-no-underline

When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.

[SergeyBiryukov]

Replying to sabernhardt:

However, I highly recommend making it consistent the other way by underlining both the author link and the button text (without underlining the spinner icon). 50697.underline-author.diff​ clearly distinguishes the blue link from the gray text.

I agree with that.

[SergeyBiryukov]

In 48564:

Accessibility: Themes: Consistently use an underline for "Enable auto-updates" link and theme author link in theme overlay.

Props chetan200891, sabernhardt, afercia.
Fixes #50697.