WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#50708 closed enhancement (fixed)

i18n: Merge similar translation strings in update functions

Reported by: ramiy Owned by:
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch has-screenshots commit
Focuses: administration Cc:

Description

See the attached patch.

Attachments (3)

50708.png (24.5 KB) - added by ramiy 17 months ago.
50708.patch (1.1 KB) - added by ramiy 17 months ago.
50708.2.patch (1.7 KB) - added by ramiy 17 months ago.

Download all attachments as: .zip

Change History (13)

@ramiy
17 months ago

@ramiy
17 months ago

#1 @ramiy
17 months ago

  • Keywords has-patch has-screenshots added

#2 @ramiy
17 months ago

Related: #50714

#3 follow-up: @ocean90
17 months ago

  • Keywords needs-refresh added
  • Type changed from defect (bug) to enhancement

I think they should be changed to "Installation failed" for consistency with the other strings in the upgrader skins.

@ramiy
17 months ago

#4 in reply to: ↑ 3 @ramiy
17 months ago

  • Keywords needs-refresh removed

Replying to ocean90:

I think they should be changed to "Installation failed" for consistency with the other strings in the upgrader skins.

Done. See the updated patch.

This ticket was mentioned in Slack in #core by ramiy. View the logs.


17 months ago

#6 @audrasjb
17 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.5

Patch looks good to me. Let's add it to milestone 5.5 as it was introduced during 5.5 beta cycle.

#7 @ocean90
17 months ago

  • Milestone changed from 5.5 to 5.6

#8 @whyisjake
17 months ago

  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in [48568].

#9 @whyisjake
17 months ago

  • Milestone changed from 5.6 to 5.5

#10 @SergeyBiryukov
17 months ago

In 48589:

I18N: Further adjust some update/install strings for consistency.

Follow-up to [48568], [48569].

See #50708, #50714.

Note: See TracTickets for help on using tickets.