WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#50708 closed enhancement (fixed)

i18n: Merge similar translation strings in update functions

Reported by: ramiy Owned by:
Priority: normal Milestone: 5.5
Component: I18N Version:
Severity: normal Keywords: has-patch has-screenshots commit
Cc: Focuses: administration

Description

See the attached patch.

Attachments (3)

50708.png​ (24.5 KB ) - added by ramiy 6 years ago.
50708.patch​ (1.1 KB ) - added by ramiy 6 years ago.
50708.2.patch​ (1.7 KB ) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (13)

@ramiy
6 years ago

@ramiy
6 years ago

#1 @ramiy
6 years ago

  • Keywords has-patch has-screenshots added

#2 @ramiy
6 years ago

Related: #50714

#3 follow-up: @ocean90
6 years ago

  • Keywords needs-refresh added
  • Type defect (bug) → enhancement

I think they should be changed to "Installation failed" for consistency with the other strings in the upgrader skins.

@ramiy
6 years ago

#4 in reply to: ↑ 3 @ramiy
6 years ago

  • Keywords needs-refresh removed

Replying to ocean90:

I think they should be changed to "Installation failed" for consistency with the other strings in the upgrader skins.

Done. See the updated patch.

This ticket was mentioned in ​Slack in #core by ramiy. ​View the logs.
6 years ago

#6 @audrasjb
6 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 5.5

Patch looks good to me. Let's add it to milestone 5.5 as it was introduced during 5.5 beta cycle.

#7 @ocean90
6 years ago

  • Milestone 5.5 → 5.6

#8 @whyisjake
6 years ago

  • Resolution → fixed
  • Status new → closed

This was fixed in [48568].

#9 @whyisjake
6 years ago

  • Milestone 5.6 → 5.5

#10 @SergeyBiryukov
6 years ago

In 48589:

I18N: Further adjust some update/install strings for consistency.

Follow-up to [48568], [48569].

See #50708, #50714.

Note: See TracTickets for help on using tickets.