WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#50709 closed enhancement (fixed)

i18n: Add context to translations strings in theme installer/upgrader/table

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: accessibility, rtl Cc:

Description

See the attached screenshot.

Attachments (3)

50709.png​ (42.4 KB) - added by ramiy 4 years ago.
50709.patch​ (1.6 KB) - added by ramiy 4 years ago.
50709.2.patch​ (1.7 KB) - added by ramiy 4 years ago.
with quotes

Download all attachments as: .zip

Change History (9)

@ramiy
4 years ago

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-patch has-screenshots added

The attached patch merges similar translation strings.

Those strings are Theme a11y strings.

Same strings in plugins files already use _x() with plugin context.

The patch fixes a11y strings in theme files.

#2 @ocean90
4 years ago

  • Keywords has-screenshots removed
  • Type changed from defect (bug) to enhancement

I'd rather leave the quotes around the plugin name to ensure it doesn't clash with a plugin name starting with "Activate", "Deactivate" or similar.

@ramiy
4 years ago

with quotes

#3 @ramiy
4 years ago

  • Summary changed from i18n: Merge similar translation strings in theme installer/upgrader to i18n: Add context to translations strings in theme installer/upgrader/table

#4 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.5

#5 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48545:

I18N: Add context to some theme strings for consistency.

Props ramiy, ocean90.
Fixes #50709.

This ticket was mentioned in ​Slack in #core by ramiy. ​View the logs.
4 years ago

Note: See TracTickets for help on using tickets.