#50710 closed defect (bug) (fixed)
i18n: Add context to theme/plugins translations strings
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.5 | Priority: | normal |
| Severity: | normal | Version: | 5.5 |
| Component: | I18N | Keywords: | has-screenshots has-patch commit |
| Focuses: | administration | Cc: |
Description
See the attached screenshots + patch.
Attachments (3)
Change History (11)
#2
@
4 years ago
When the string contains the word Plugin/Theme, it's easier to translate (to Hebrew). But, it's not always the case...
#3
@
4 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 5.5
- Version set to trunk
Related: #9757
As those changes come from 5.5, I think it's worth fixing this before 5.5 is released.
Changes looks good to me, milestoning to 5.5.
#4
@
4 years ago
- Keywords i18n-change added
Adding i18n-change workflow keyword as new strings were already deployed.
#5
follow-up:
↓ 7
@
4 years ago
- Keywords i18n-change removed
The i18n-change keyword is generally used after string freeze, which hasn't been announced yet, so the keyword is not necessary at this point :)
#6
@
4 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 48520:
#7
in reply to:
↑ 5
@
4 years ago
Replying to SergeyBiryukov:
The
i18n-changekeyword is generally used after string freeze, which hasn't been announced yet, so the keyword is not necessary at this point :)
Got it, thanks and sorry for the confusion :)
WordPress 5.5 added many themes/plugins translation strings. Many strings use
_x()with context. But not all the strings. The attached patch adds context to some of those strings (install and update).I should add that in Hebrew language Plugin is a male and Theme is a female ( תוסף מפורסם, תבנית יפה ).