Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50711, comment 2


Ignore:
Timestamp:
07/21/2020 02:44:07 AM (6 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50711, comment 2

    initial v1  
    11Ideally it can be like 50711-extended.diff, the new attachment post is created and the `X-WP-Upload-Attachment-ID` header is set before any edits are applied to the image. Then it can retry on all possible failures. However there are few caveats:
    22- Standard API errors cannot be HTTP 500 or they will trigger retries.
    3 - Currently on the js side it can only retry to create image sub-sizes. Would need to handle cases (repeat the request) if the server fails while cropping or rotation the image.
     3- Currently on the js side it can only retry to create image sub-sizes. Would need to handle cases (repeat the request) if the server fails while cropping or rotating the image.
    44
    55Lets improve this in 5.6.