WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 2 weeks ago

#50714 closed enhancement (fixed)

i18n: Merge similar translation strings in updates.js

Reported by: ramiy Owned by: whyisjake
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.5
Component: I18N Keywords: has-patch
Focuses: administration Cc:

Description

See the attached patch.

Attachments (4)

50714.png (23.0 KB) - added by ramiy 10 months ago.
50714.2.png (23.0 KB) - added by ramiy 10 months ago.
50714.patch (717 bytes) - added by ramiy 10 months ago.
50714.2.patch (1.1 KB) - added by ramiy 10 months ago.

Download all attachments as: .zip

Change History (13)

@ramiy
10 months ago

@ramiy
10 months ago

@ramiy
10 months ago

#1 @ramiy
10 months ago

  • Keywords has-screenshots has-patch added

#2 @ocean90
10 months ago

  • Keywords close needs-refresh added; has-screenshots removed
  • Type changed from defect (bug) to enhancement

Removing has-screenshots since it's more intended for screenshots from the actual UI where we can see the strings in WordPress.

50714.patch will make the button labels inconsistent. The other button labels aren't using sentence case, there's also Installation Failed!.

#3 @ramiy
10 months ago

Related: #50708

@ramiy
10 months ago

#4 @ramiy
10 months ago

  • Keywords close needs-refresh removed

Patch updated according your feedback at https://core.trac.wordpress.org/ticket/50708#comment:3

This ticket was mentioned in Slack in #core by ramiy. View the logs.


10 months ago

#6 @whyisjake
10 months ago

  • Owner set to whyisjake
  • Resolution set to fixed
  • Status changed from new to closed

In 48569:

i18n: Merge similar translation strings to "Update failed".

Fixes #50714.
Props ramiy, ocean90.

#7 @whyisjake
10 months ago

  • Milestone changed from Awaiting Review to 5.5
  • Version set to trunk

#8 @SergeyBiryukov
10 months ago

In 48589:

I18N: Further adjust some update/install strings for consistency.

Follow-up to [48568], [48569].

See #50708, #50714.

#9 @Hareesh Pillai
2 weeks ago

#42520 was marked as a duplicate.

Note: See TracTickets for help on using tickets.