WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#50714 closed enhancement (fixed)

i18n: Merge similar translation strings in updates.js

Reported by: ramiy Owned by: whyisjake
Priority: normal Milestone: 5.5
Component: I18N Version: 5.5
Severity: normal Keywords: has-patch
Cc: Focuses: administration

Description

See the attached patch.

Attachments (4)

50714.png​ (23.0 KB ) - added by ramiy 6 years ago.
50714.2.png​ (23.0 KB ) - added by ramiy 6 years ago.
50714.patch​ (717 bytes ) - added by ramiy 6 years ago.
50714.2.patch​ (1.1 KB ) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (13)

@ramiy
6 years ago

@ramiy
6 years ago

@ramiy
6 years ago

#1 @ramiy
6 years ago

  • Keywords has-screenshots has-patch added

#2 @ocean90
6 years ago

  • Keywords close needs-refresh added; has-screenshots removed
  • Type defect (bug) → enhancement

Removing has-screenshots since it's more intended for screenshots from the actual UI where we can see the strings in WordPress.

50714.patch​ will make the button labels inconsistent. The other button labels aren't using sentence case, there's also Installation Failed!.

#3 @ramiy
6 years ago

Related: #50708

@ramiy
6 years ago

#4 @ramiy
6 years ago

  • Keywords close needs-refresh removed

Patch updated according your feedback at https://core.trac.wordpress.org/ticket/50708#comment:3

This ticket was mentioned in ​Slack in #core by ramiy. ​View the logs.
6 years ago

#6 @whyisjake
6 years ago

  • Owner set to whyisjake
  • Resolution → fixed
  • Status new → closed

In 48569:

i18n: Merge similar translation strings to "Update failed".

Fixes #50714.
Props ramiy, ocean90.

#7 @whyisjake
6 years ago

  • Milestone Awaiting Review → 5.5
  • Version → trunk

#8 @SergeyBiryukov
6 years ago

In 48589:

I18N: Further adjust some update/install strings for consistency.

Follow-up to [48568], [48569].

See #50708, #50714.

#9 @Hareesh Pillai
5 years ago

#42520 was marked as a duplicate.

Note: See TracTickets for help on using tickets.