Opened 5 years ago
Closed 5 years ago
#50724 closed defect (bug) (fixed)
Sitemaps: rename 'sitemap' to 'provider' in registry class
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 5.5 |
Component: | Sitemaps | Keywords: | has-patch |
Focuses: | Cc: |
Description
This would have helped prevent a bug like #50666.
This class is for registering sitemap providers, not individual sitemaps.
Attachments (4)
Change History (14)
#2
@
5 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
#3
@
5 years ago
50724.2.diff additionally changes:
wp_get_sitemaps()
towp_get_sitemaps_providers()
- a couple of occurrences of
$sitemaps = $registry->get_providers()
to$providers = $registry->get_providers()
in the unit tests
#8
@
5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reviewing the draft sitemaps dev-note, I noticed one more function that needs to be renamed: wp_register_sitemap()
to wp_register_sitemap_provider()
.
50724.4.diff does that.
This ticket was mentioned in Slack in #core-sitemaps by pbiron. View the logs.
5 years ago
Note: See
TracTickets for help on using
tickets.
In 48536: