Context Navigation

← Previous Ticket
Next Ticket →

#50724 closed defect (bug) (fixed)

Sitemaps: rename 'sitemap' to 'provider' in registry class

Reported by:	swissspidy	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.5
Component:	Sitemaps	Version:	5.5
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

This would have helped prevent a bug like #50666.

This class is for registering sitemap providers, not individual sitemaps.

Attachments (4)

50724.diff (8.1 KB ) - added by swissspidy 6 years ago.
50724.2.diff (6.5 KB ) - added by pbiron 6 years ago.
50724.3.diff (7.2 KB ) - added by swissspidy 6 years ago.
50724.4.diff (2.0 KB ) - added by pbiron 6 years ago.: rename wp_register_sitemap() to wp_register_sitemap_provider()

Download all attachments as: .zip

Change History (14)

@swissspidy
6 years ago

Attachment 50724.diff added

#1 @swissspidy
6 years ago

Milestone Awaiting Review → 5.5
Version → trunk

#2 @SergeyBiryukov
6 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 48536:

Sitemaps: Rename 'sitemap' to 'provider' in WP_Sitemaps_Registry class.

This class is for registering sitemap providers, not individual sitemaps.

Props swissspidy.
Fixes #50724.

@pbiron
6 years ago

Attachment 50724.2.diff added

#3 @pbiron
6 years ago

50724.2.diff additionally changes:

wp_get_sitemaps() to wp_get_sitemaps_providers()
a couple of occurrences of $sitemaps = $registry->get_providers() to $providers = $registry->get_providers() in the unit tests

#4 @SergeyBiryukov
6 years ago

Resolution fixed
Status closed → reopened

@swissspidy
6 years ago

Attachment 50724.3.diff added

#5 @swissspidy
6 years ago

In 48540:

Sitemaps: Rename wp_get_sitemaps() to wp_get_sitemaps_providers()

Following [48536], rename the function to match the rest of the sitemaps logic.

Also eliminates some dead code after [48523].

Props pbiron.
See #50724. See #50643.

#6 @SergeyBiryukov
6 years ago

In 48541:

Sitemaps: Rename wp_get_sitemaps_providers() to wp_get_sitemap_providers().

Follow-up to [48536], [48540].

Props pbiron, swissspidy, SergeyBiryukov.
See #50724.

#7 @SergeyBiryukov
6 years ago

Resolution → fixed
Status reopened → closed

@pbiron
6 years ago

Attachment 50724.4.diff added

rename wp_register_sitemap() to wp_register_sitemap_provider()

#8 @pbiron
6 years ago

Resolution fixed
Status closed → reopened

Reviewing the draft sitemaps dev-note, I noticed one more function that needs to be renamed: wp_register_sitemap() to wp_register_sitemap_provider().

50724.4.diff does that.

This ticket was mentioned in Slack in #core-sitemaps by pbiron. View the logs.

6 years ago

#10 @SergeyBiryukov
6 years ago

Resolution → fixed
Status reopened → closed

In 48553:

Sitemaps: Rename wp_register_sitemap() to wp_register_sitemap_provider().

Follow-up to [48536], [48540], [48541].

Props pbiron.
Fixes #50724.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#50724 closed defect (bug) (fixed)

Sitemaps: rename 'sitemap' to 'provider' in registry class

Description

Attachments (4)

Change History (14)

@swissspidy 6 years ago

#1 @swissspidy 6 years ago

#2 @SergeyBiryukov 6 years ago

@pbiron 6 years ago

#3 @pbiron 6 years ago

#4 @SergeyBiryukov 6 years ago

@swissspidy 6 years ago

#5 @swissspidy 6 years ago

#6 @SergeyBiryukov 6 years ago

#7 @SergeyBiryukov 6 years ago

@pbiron 6 years ago

#8 @pbiron 6 years ago

This ticket was mentioned in ​Slack in #core-sitemaps by pbiron. ​View the logs. 6 years ago

#10 @SergeyBiryukov 6 years ago

Download in other formats:

@swissspidy
6 years ago

#1 @swissspidy
6 years ago

#2 @SergeyBiryukov
6 years ago

@pbiron
6 years ago

#3 @pbiron
6 years ago

#4 @SergeyBiryukov
6 years ago

@swissspidy
6 years ago

#5 @swissspidy
6 years ago

#6 @SergeyBiryukov
6 years ago

#7 @SergeyBiryukov
6 years ago

@pbiron
6 years ago

#8 @pbiron
6 years ago

This ticket was mentioned in Slack in #core-sitemaps by pbiron. View the logs.

6 years ago

#10 @SergeyBiryukov
6 years ago