WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#50741 closed defect (bug) (fixed)

Translation error / typo when using phpunit-test-runner

Reported by: a2hosting Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.5
Component: Build/Test Tools Keywords:
Focuses: privacy Cc:

Description

We're seeing failing tests when using the phpunit-test-report and phpunit-test-runner. Looks to be a small typo or error in translation:

There were 2 failures:

1) Tests_User_WpSendUserRequest::test_should_send_user_request_email_in_user_locale
Failed asserting that '[Test Blog] Confirmar la acción: Exportar los datos personales' contains "Confirma la".

/var/www/vhosts/wp-test-runner/tests/phpunit/tests/user/wpSendUserRequest.php:295

2) Tests_User_WpSendUserRequest::test_should_send_user_request_email_in_user_locale_when_admin_and_site_have_different_locales
Failed asserting that '[Test Blog] Confirmar la acción: Exportar los datos personales' contains "Confirma la".

/var/www/vhosts/wp-test-runner/tests/phpunit/tests/user/wpSendUserRequest.php:339

Change History (3)

#1 @SergeyBiryukov
3 months ago

  • Component changed from General to Build/Test Tools
  • Focuses privacy added

#2 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.5

Hi there, welcome to WordPress Trac! Thanks for the report.

It looks like "Confirmar la acción" is indeed the current translation for that string.

This doesn't fail on WP Travis because the test suite uses its own translation files, which would need an update too.

#3 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48581:

Tests: Update the es_ES string used in wp_send_user_request() tests to match the current translation.

Props a2hosting.
Fixes #50741.

Note: See TracTickets for help on using tickets.