WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#50743 closed defect (bug) (fixed)

i18n: Merge similar translation strings in privacy tools

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile sergeybiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch has-privacy-review
Focuses: administration Cc:

Description

See the attached patch.

Attachments (3)

50743.png​ (7.4 KB) - added by ramiy 4 years ago.
50743.patch​ (598 bytes) - added by ramiy 4 years ago.
50743.2.patch​ (669 bytes) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (12)

@ramiy
4 years ago

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-screenshots has-patch added

#2 @carike
4 years ago

Could you please discuss this in the #core-privacy channel?
When it comes to compliance-related matters, words have very specific meanings sometimes and changing it may be inadvisable. It would be good to have a chat about it first.

#3 @carike
4 years ago

  • Keywords needs-privacy-review added

This ticket was mentioned in ​Slack in #core-privacy by ramiy. ​View the logs.
4 years ago

#5 @ramiy
4 years ago

We have two similar translation strings in privacy pages.

  • Return to top in wp-admin/includes/privacy-tools.php
  • Return to Top in wp-admin/includes/class-wp-privacy-policy-content.php

The patch has a minor change. Does it has any privacy repercussion?

#6 @carike
4 years ago

  • Keywords has-privacy-review added; needs-privacy-review removed
  • Milestone changed from Awaiting Review to 5.5

Nope. The attachments were not visible yet when I opened the ticket.
Will change the workflow now :)

#7 @whyisjake
4 years ago

I think in the quest to sentence case everything, we probably want to use the Return to top option.

#8 @ramiy
4 years ago

Ok, I'm updating the patch.

@ramiy
4 years ago

#9 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48588:

I18N: Merge two "Return to top" strings.

Props ramiy, carike, whyisjake.
Fixes #50743.

Note: See TracTickets for help on using tickets.