WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 weeks ago

#50747 closed defect (bug) (duplicate)

i18n: Merge similar translation strings in bulk actions

Reported by: ramiy Owned by: sergeybiryukov
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: administration, multisite Cc:

Description

See the attached screenshots + patch.

Attachments (4)

50747a.2.png (22.1 KB) - added by ramiy 4 months ago.
50747b.png (63.7 KB) - added by ramiy 4 months ago.
50747.patch (1.5 KB) - added by ramiy 4 months ago.
50747.2.patch (7.6 KB) - added by justinahinon 3 months ago.

Download all attachments as: .zip

Change History (19)

@ramiy
4 months ago

@ramiy
4 months ago

@ramiy
4 months ago

#1 @ramiy
4 months ago

  • Keywords has-screenshots has-patch added

#2 @audrasjb
4 months ago

  • Keywords 2nd-opinion added

Hi and thanks @ramiy,

However I'm not sure we'll want to apply the proposed patch as it would introduce an inconsistency between those strings and the other strings in the selector.

In plugins list, it would lead us to:

  • Network Activate
  • Enable Auto-updates

While it would be better to sentence-case all the strings, I'm not sure we want to touch other already translated strings like "Network Activate".

If there is no problem to touch existing freeze right before RC1, we should use "Network activate" on the other string. If not, we should probably wait for 5.6 (or next minor).

Any thought, @SergeyBiryukov?

PS: it looks like the current patch wasn't generated against trunk. It doesn't apply on my wordpress-develop instance.

Cheers,
Jb

#3 @ramiy
4 months ago

Good point @audrasjb.

We can apply the plugin bulk actions on WordPress 5.5 and postponed the network bulk actions to WordPress 5.6.

#4 @SergeyBiryukov
4 months ago

  • Milestone changed from Awaiting Review to 5.5

It looks like most of the bulk actions were already moved to sentence case in [48352] / #40244, so let's address this too.

#5 @SergeyBiryukov
4 months ago

  • Milestone changed from 5.5 to 5.6

Upon a closer look, some of these strings are not only used in bulk actions, but also in row actions for a single plugin or theme. These row actions are not yet switched to sentence case across the admin, so let's make sure we're not introducing new inconsistencies while fixing others.

The list of affected strings:

  • Enable Auto-updates
  • Disable Auto-updates
  • Network Activate
  • Network Deactivate
  • Network Enable
  • Network Disable
Last edited 4 months ago by SergeyBiryukov (previous) (diff)

#6 @audrasjb
4 months ago

  • Keywords needs-refresh added; 2nd-opinion removed

Agree. Let's address this in next major 👍

#7 @ramiy
4 months ago

@SergeyBiryukov @audrasjb

Another workaround, to moved these strings to sentence case. But in row actions change the display using CSS:

text-transform: capitalize;

This way we merge similar strings and reduce the total number of strings, but the user won't see any change in the UI.

#8 @audrasjb
4 months ago

I think it's not a good idea. It will change the text visually, so only for sighten users.
It's a pretty bad experience in term of accessibility.

It's a lot better to have more strings to translate than to decrease the interface accessibility 🙂

#10 @justinahinon
3 months ago

In 50747.2.patch, refreshed the patch on trunk and add fixes the others inconsistencies mentionned by Sergey.

#11 @audrasjb
3 months ago

  • Keywords needs-refresh removed

Thanks @justinahinon the proposed patch looks good to me 👍

#12 @justinahinon
3 months ago

@audrasjb looks like it has already been patched in https://core.trac.wordpress.org/ticket/50773: https://core.trac.wordpress.org/attachment/ticket/50773/50773.diff.

I think that one should be committed. I'll ask again during the scrub this afternoon.

(Haven't tested it yet though).

Last edited 3 months ago by justinahinon (previous) (diff)

This ticket was mentioned in Slack in #core by justinahinon. View the logs.


2 months ago

#14 @hellofromTonya
4 weeks ago

Duplicate #50773.

Per this scrub, props within this ticket will be given when merging #50773.

#15 @SergeyBiryukov
3 weeks ago

  • Milestone 5.6 deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

Let's merge this ticket with #50773, as the latest patch there includes these changes.

Note: See TracTickets for help on using tickets.