i18n: Merge similar translation strings in bulk actions

[ramiy]

See the attached screenshots + patch.

[audrasjb]

Hi and thanks @ramiy,

However I'm not sure we'll want to apply the proposed patch as it would introduce an inconsistency between those strings and the other strings in the selector.

In plugins list, it would lead us to:

• Network Activate
• Enable Auto-updates

While it would be better to sentence-case all the strings, I'm not sure we want to touch other already translated strings like "Network Activate".

If there is no problem to touch existing freeze right before RC1, we should use "Network activate" on the other string. If not, we should probably wait for 5.6 (or next minor).

Any thought, @SergeyBiryukov?

PS: it looks like the current patch wasn't generated against trunk. It doesn't apply on my wordpress-develop instance.

Cheers,
Jb

[ramiy]

Good point @audrasjb.

We can apply the plugin bulk actions on WordPress 5.5 and postponed the network bulk actions to WordPress 5.6.

[SergeyBiryukov]

It looks like most of the bulk actions were already moved to sentence case in [48352] / #40244, so let's address this too.

[SergeyBiryukov]

Upon a closer look, some of these strings are used not only in bulk actions, but only in row actions for a single plugin or theme. These row actions are not yet switched to sentence case across the admin, so let's make sure we're not introducing new inconsistencies while fixing others.

The list of affected strings:

• Enable Auto-updates
• Disable Auto-updates
• Network Activate
• Network Deactivate
• Network Enable
• Network Disable

[audrasjb]

Agree. Let's address this in next major 👍

[ramiy]

@SergeyBiryukov @audrasjb

Another workaround, to moved these strings to sentence case. But in row actions change the display using CSS:

text-transform: capitalize;

This way we merge similar strings and reduce the total number of strings, but the user won't see any change in the UI.

[audrasjb]

I think it's not a good idea. It will change the text visually, so only for sighten users.
It's a pretty bad experience in term of accessibility.

It's a lot better to have more strings to translate than to decrease the interface accessibility 🙂

[SergeyBiryukov]

Related: #50773

[justinahinon]

In 50747.2.patch, refreshed the patch on trunk and add fixes the others inconsistencies mentionned by Sergey.

[audrasjb]

Thanks @justinahinon the proposed patch looks good to me 👍

[justinahinon]

@audrasjb looks like it has already been patched in https://core.trac.wordpress.org/ticket/50773: https://core.trac.wordpress.org/attachment/ticket/50773/50773.diff.

I think that one should be committed. I'll ask again during the scrub this afternoon.

(Haven't tested it yet though).

[hellofromTonya]

Duplicate #50773.

​Per this scrub, props within this ticket will be given when merging #50773.

[SergeyBiryukov]

Let's merge this ticket with #50773, as the latest patch there includes these changes.