#50766 closed defect (bug) (fixed)
Not enough padding on "Warning: these page should not be the same!"
Reported by: | SergeyBiryukov | Owned by: | Shital Patel |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | good-first-bug has-screenshots has-patch needs-testing |
Focuses: | ui, css | Cc: |
Description (last modified by )
- Go to Reading Settings.
- Assign the same page as Homepage and Posts page.
- You'll see the two messages: "Settings saved" and "Warning: these page should not be the same!".
- The first message has enough padding, while the second one does not.
This is caused by generic form table styles:
.form-table td p { margin-top: 4px; margin-bottom: 0; }
taking precedence over
div.error p { margin: 0.5em 0; padding: 2px; }
Adding a notice
class to the message fixes the issue.
Note: This also applies to "Warning: these pages should not be the same as your Privacy Policy page!" directly below.
Attachments (3)
Change History (13)
#3
in reply to:
↑ 2
@
4 years ago
Replying to man4toman:
In addition, I think
inline
class name is not required here.
It can be:class="notice error"
I think if you take away the inline
class, it will put the warning at the top of the page. I'm assuming the intended design is to warn at the location where the questionable action was taken.
This ticket was mentioned in PR #438 on WordPress/wordpress-develop by musicaljoeker.
4 years ago
#4
- Keywords has-patch added; needs-patch removed
…same!" warning
Adding the notice
class to the warning fixes this problem.
Props SergeyBiryukov, man4toman.
Fixes #50766
Added the notice
class to the Reading Settings front-page-warning
.
Trac ticket: https://core.trac.wordpress.org/ticket/50766
#5
follow-up:
↓ 6
@
4 years ago
@SergeyBiryukov should the error
class be replaced by notice notice-info
instead of just adding notice
?
Just asking to see if it should conform to the commit here.
#6
in reply to:
↑ 5
@
4 years ago
Replying to garrett-eclipse:
should the
error
class be replaced bynotice notice-info
instead of just addingnotice
?
Just asking to see if it should conform to the commit here.
Yeah, it could be replaced with notice notice-error
or notice notice-warning
, since this message is a warning, rather than just info, unlike the one in [48145].
That said, it looks like there are still a lot of messages with the legacy error
class in the admin, so that might be something to handle in another ticket for all of them.
This ticket was mentioned in Slack in #core-css by kirstyburgoine. View the logs.
4 years ago
#8
@
4 years ago
- Keywords needs-testing added
- Owner set to Shital Patel
- Status changed from new to accepted
dream-encode commented on PR #438:
4 years ago
#10
Merged into WP Core in https://core.trac.wordpress.org/changeset/48906
In addition, I think
inline
class name is not required here.It can be:
class="notice error"