WordPress.org

Make WordPress Core

Opened 8 weeks ago

Last modified 21 hours ago

#50773 new defect (bug)

Merge duplicate strings in bulk actions and row actions for list tables

Reported by: SergeyBiryukov Owned by:
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch needs-testing
Focuses: ui, administration Cc:

Description

Backround: #40244, #50747.

As noted by @ramiy in comment:25:ticket:40244 and me in comment:5:ticket:50747, as part of the changes in [48352] and [48595] some strings were duplicated with a different case:

  • _x( 'Not Spam', 'comment' )
  • _x( 'Not spam', 'comment' )
  • _x( 'Not Spam', 'site' )
  • _x( 'Not spam', 'site' )

Additionally, some strings kept title casing and should be switched to sentence casing for consistency with others:

  • __( 'Enable Auto-updates' )
  • __( 'Disable Auto-updates' )
  • __( 'Network Activate' )
  • __( 'Network Deactivate' )
  • __( 'Network Enable' )
  • __( 'Network Disable' )

The problem is that some of these strings are not only used in bulk actions, but also in row actions.

While most of bulk action strings appear to be switched to sentence casing across the admin now, row actions are not. It seems like that would be the next step to bring some consistency here.

Attachments (1)

50773.diff (35.4 KB) - added by dkotter 4 weeks ago.

Download all attachments as: .zip

Change History (9)

#1 in reply to: ↑ description @ramiy
8 weeks ago

Replying to SergeyBiryukov:

While most of bulk action strings appear to be switched to sentence casing across the admin now, row actions are not. It seems like that would be the next step to bring some consistency here.

I agree, the next logical step is to use sentence casing in "Row Actions".

@dkotter
4 weeks ago

#2 @dkotter
4 weeks ago

I've gone through all of the list-table classes and updated strings to use sentence case, where they were previously using title case.

This should take care of the "Row Actions" but might impact other areas as well. If the goal is to tackle those strings in a different ticket, I can clean up my patch to focus only on the "Row Actions". Just seemed to make the most sense to fix all of those at once.

#3 @garrett-eclipse
3 weeks ago

  • Keywords has-patch needs-testing added

#4 follow-up: @ramiy
3 weeks ago

Does the patch include translation strings from #50747 ?

#5 in reply to: ↑ 4 @dkotter
3 days ago

Replying to ramiy:

Does the patch include translation strings from #50747 ?

Yes, this contains those updates

This ticket was mentioned in Slack in #core by helen. View the logs.


45 hours ago

#7 @helen
44 hours ago

I see some changes on the latest patch in #50747 that aren't in this patch - could we perhaps pick one ticket and merge patches together? And a review for consistency across these UIs would be nice :)

#8 @justinahinon
21 hours ago

I'll go through both and update the patch.

Note: See TracTickets for help on using tickets.