Make WordPress Core

Opened 4 years ago

Closed 22 months ago

#50785 closed enhancement (fixed)

Error-Messages with <strong>-tag could need some makeover/unification.

Reported by: transl8or's profile transl8or Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.5
Component: Text Changes Keywords: has-patch
Focuses: ui-copy Cc:

Description

We have two different ways of formatting the word "Error:" with the <strong>-tag in the error messages.

1) <strong>Error</strong>: Here comes text with more information. [53 cases in WP55Beta3]

2) <strong>Error:</strong> Here comes text with more information. [8 cases in WP55Beta3]

Can we agree on a variant and unify it for consistency?

I would prefer variant (2), even if that means a lot of new (fuzzy) strings in the translations to revise.

Attachments (4)

Error-Messages-61Results-wp55beta3.png (37.4 KB) - added by transl8or 4 years ago.
Files matching the Search for "<strong>Error"
2-Error-Message-8Results-wp55beta3.png (31.9 KB) - added by transl8or 4 years ago.
Details in which files variant 2) can be found]:
1-Error-Message-53Results-wp55beta3.png (174.0 KB) - added by transl8or 4 years ago.
Details in which files variant 1) can be found:
50785.diff (26.9 KB) - added by mihaidumitrascu 22 months ago.

Download all attachments as: .zip

Change History (15)

@transl8or
4 years ago

Files matching the Search for "<strong>Error"

@transl8or
4 years ago

Details in which files variant 2) can be found]:

@transl8or
4 years ago

Details in which files variant 1) can be found:

#1 @SergeyBiryukov
4 years ago

  • Component changed from Formatting to Text Changes

#2 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

#3 @sabernhardt
2 years ago

  • Focuses ui-copy added

#4 @sabernhardt
22 months ago

  • Component changed from Text Changes to General

#5 @mihaidumitrascu
22 months ago

  • Keywords has-patch added; needs-patch removed

#6 @audrasjb
22 months ago

  • Component changed from General to Text Changes
  • Milestone changed from Future Release to 6.1
  • Owner set to audrasjb
  • Status changed from new to reviewing

Thanks for the patch!
Self assigning for review.

This ticket was mentioned in PR #2776 on WordPress/wordpress-develop by audrasjb.


22 months ago
#7

Trac ticket:

#8 @audrasjb
22 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53458:

Text Changes: Improve consistency of admin error notices.

This changeset replaces <strong>Error</strong>: with <strong>Error:</strong>, for better consistency.

Props transl8or, mihaidumitrascu, audrasjb.
Fixes #50785.

audrasjb commented on PR #2776:


22 months ago
#9

committed

#10 @audrasjb
22 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to address a missed occurence in wp-admin/options.php.

#11 @audrasjb
22 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53476:

Text Changes: Improve consistency of admin error notices in wp-admin/options.php.

This changeset replaces <strong>Error</strong>: with <strong>Error:</strong>, for better consistency.

Follow-up to [53458].

Fixes #50785.

Note: See TracTickets for help on using tickets.