WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #50789, comment 3


Ignore:
Timestamp:
07/28/2020 03:41:18 PM (6 months ago)
Author:
andy
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50789, comment 3

    v1 v2  
    1414> I probably wouldn't query `information_schema` directly in this situation for this reason. WooCommerce ''should'' be storing a version as an option for each of its custom tables, and the values of those options should dictate what SQL is generated. (This is also the approach I've taken in the [https://github.com/berlindb/core BerlinDB] project.)
    1515
    16 We agree that `information_schema` queries should be avoided. I can't speak for the WooCommerce logic of using both a stored version number and a schema check. But WooCommerce got a pull request to replace the `information_schema` query with a `SHOW CREATE TABLE`: https://github.com/Automattic/woocommerce/pull/84
     16We agree that `information_schema` queries should be avoided. I can't speak for the WooCommerce logic of using both a stored version number and a schema check. But WooCommerce got a pull request to replace the `information_schema` query with a `SHOW CREATE TABLE`.