WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#50800 closed defect (bug) (invalid)

Fix a typo in about.php page

Reported by: B-07 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch
Focuses: ui Cc:

Description

Change History (4)

#1 @SergeyBiryukov
18 months ago

  • Component changed from General to Help/About
  • Keywords i18n-change added
  • Milestone changed from Awaiting Review to 5.5

#2 @JeffPaul
18 months ago

  • Component changed from Help/About to General
  • Keywords i18n-change removed
  • Milestone changed from 5.5 to Awaiting Review

@B-07 I believe the grammar is correct in the existing code and thus your PR and this Trac ticket can likely be closed. Thanks for helping review the text and calling out your concern though!

#3 follow-up: @JeffPaul
18 months ago

  • Component changed from General to Help/About
  • Keywords close i18n-change added
  • Milestone changed from Awaiting Review to 5.5

Oof, my comment inadvertently changed Sergey's classifications, I'll update those accordingly. If you're ok I'd recommend we close as invalid?

#4 in reply to: ↑ 3 @SergeyBiryukov
18 months ago

  • Keywords close i18n-change removed
  • Milestone 5.5 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Yes, the grammar seems correct to me as is. I've moved the ticket to the milestone before looking at the PR :)

See one of the examples on https://www.merriam-webster.com/dictionary/impact:

to have an impact —often used with on

Thanks for the review though!

Last edited 18 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.