WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 9 days ago

Last modified 9 days ago

#50805 closed defect (bug) (fixed)

i18n: Merge similar translation strings in rest api block types

Reported by: ramiy Owned by: sergeybiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: rest-api Cc:

Description

See the attached patch.

This patch does not effects the string freeze. It does not adds new translation strings. It removes a string.

Attachments (6)

50805.png (12.1 KB) - added by ramiy 2 months ago.
50805.patch (575 bytes) - added by ramiy 2 months ago.
50805.2.2.patch (729 bytes) - added by ramiy 2 months ago.
50805.3.patch (2.3 KB) - added by ramiy 2 months ago.
50805.4.2.patch (2.3 KB) - added by justinahinon 2 weeks ago.
50805.6.diff (1.3 KB) - added by garrett-eclipse 9 days ago.
Update to account for qunit wp-api-generated.js fixture changes

Download all attachments as: .zip

Change History (19)

@ramiy
2 months ago

@ramiy
2 months ago

#1 @ramiy
2 months ago

  • Keywords has-screenshots has-patch added

#2 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.5.1

Good catch! The Block name string directly above would also have to be changed to Block name. though, for consistency with other description properties, which would add a new string.

Let's clean this up in 5.5.1.

@ramiy
2 months ago

@ramiy
2 months ago

#3 @ramiy
2 months ago

Found few more...

#4 @ramiy
2 months ago

If not 5.5 milestone, then 5.6 milestone.

We should not change translation strings in minor version.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


6 weeks ago

#6 @SergeyBiryukov
5 weeks ago

  • Milestone changed from 5.5.1 to 5.6

Moving to 5.6 per comment:4, to minimize the number of string changes in 5.5.1.

#7 @justinahinon
2 weeks ago

@ramiy your last patch looks fine but doesn't apply correctly against WordPress trunk. I've updated it with the same changes.

This ticket was mentioned in Slack in #core by justinahinon. View the logs.


2 weeks ago

#9 @helen
2 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48982:

i18n: Ensure block type strings in the REST API end with a full stop.

Props ramiy, justinahinon.
Fixes #50805.

This ticket was mentioned in Slack in #core by timothybjacobs. View the logs.


9 days ago

@garrett-eclipse
9 days ago

Update to account for qunit wp-api-generated.js fixture changes

#11 @garrett-eclipse
9 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to address the qunit wp-api-generated.js fixture as it uses these strings. Uploaded patch 50805.6.diff.

#12 @TimothyBlynJacobs
9 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49031:

REST API: Regenerate test fixtures after [48982].

Props garrett-eclipse.
Fixes #50805.

#13 @TimothyBlynJacobs
9 days ago

Good catch, thanks for the patch @garrett-eclipse!

Note: See TracTickets for help on using tickets.