![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#50805 closed defect (bug) (fixed)
i18n: Merge similar translation strings in rest api block types
| Reported by: | ramiy | Owned by: | sergeybiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.6 |
| Component: | I18N | Version: | |
| Severity: | normal | Keywords: | has-screenshots has-patch |
| Cc: | Focuses: | rest-api |
Description
See the attached patch.
This patch does not effects the string freeze. It does not adds new translation strings. It removes a string.
Attachments (6)
Change History (19)
#4
@
6 years ago
If not 5.5 milestone, then 5.6 milestone.
We should not change translation strings in minor version.
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
6 years ago
#6
@
6 years ago
- Milestone 5.5.1 → 5.6
Moving to 5.6 per comment:4, to minimize the number of string changes in 5.5.1.
#7
@
6 years ago
@ramiy your last patch looks fine but doesn't apply correctly against WordPress trunk. I've updated it with the same changes.
This ticket was mentioned in Slack in #core by justinahinon. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by timothybjacobs. View the logs.
6 years ago
#11
@
6 years ago
- Resolution fixed
- Status closed → reopened
Reopening to address the qunit wp-api-generated.js fixture as it uses these strings. Uploaded patch 50805.6.diff.
Good catch! The
Block namestring directly above would also have to be changed toBlock name.though, for consistency with otherdescriptionproperties, which would add a new string.Let's clean this up in 5.5.1.