WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#50805 closed defect (bug) (fixed)

i18n: Merge similar translation strings in rest api block types

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile sergeybiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: rest-api Cc:

Description

See the attached patch.

This patch does not effects the string freeze. It does not adds new translation strings. It removes a string.

Attachments (6)

50805.png​ (12.1 KB) - added by ramiy 4 years ago.
50805.patch​ (575 bytes) - added by ramiy 4 years ago.
50805.2.2.patch​ (729 bytes) - added by ramiy 4 years ago.
50805.3.patch​ (2.3 KB) - added by ramiy 4 years ago.
50805.4.2.patch​ (2.3 KB) - added by justinahinon 4 years ago.
50805.6.diff​ (1.3 KB) - added by garrett-eclipse 4 years ago.
Update to account for qunit wp-api-generated.js fixture changes

Download all attachments as: .zip

Change History (19)

@ramiy
4 years ago

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-screenshots has-patch added

#2 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.5.1

Good catch! The Block name string directly above would also have to be changed to Block name. though, for consistency with other description properties, which would add a new string.

Let's clean this up in 5.5.1.

@ramiy
4 years ago

@ramiy
4 years ago

#3 @ramiy
4 years ago

Found few more...

#4 @ramiy
4 years ago

If not 5.5 milestone, then 5.6 milestone.

We should not change translation strings in minor version.

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
4 years ago

#6 @SergeyBiryukov
4 years ago

  • Milestone changed from 5.5.1 to 5.6

Moving to 5.6 per comment:4, to minimize the number of string changes in 5.5.1.

@justinahinon
4 years ago

#7 @justinahinon
4 years ago

@ramiy your last patch looks fine but doesn't apply correctly against WordPress trunk. I've updated it with the same changes.

This ticket was mentioned in ​Slack in #core by justinahinon. ​View the logs.
4 years ago

#9 @helen
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48982:

i18n: Ensure block type strings in the REST API end with a full stop.

Props ramiy, justinahinon.
Fixes #50805.

This ticket was mentioned in ​Slack in #core by timothybjacobs. ​View the logs.
4 years ago

@garrett-eclipse
4 years ago

Update to account for qunit wp-api-generated.js fixture changes

#11 @garrett-eclipse
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to address the qunit wp-api-generated.js fixture as it uses these strings. Uploaded patch 50805.6.diff.

#12 @TimothyBlynJacobs
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49031:

REST API: Regenerate test fixtures after [48982].

Props garrett-eclipse.
Fixes #50805.

#13 @TimothyBlynJacobs
4 years ago

Good catch, thanks for the patch @garrett-eclipse!

Note: See TracTickets for help on using tickets.