![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#50809 closed defect (bug) (fixed)
Twenty Thirteen: Wrong color for social icons
| Reported by: | desrosj | Owned by: | desrosj |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.6 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-screenshots good-first-bug has-patch commit |
| Cc: | Focuses: |
Description
When using the social block in Twenty Thirteen, the link colors are overridden.
This happens with all three block styles provided by default.
Attachments (7)
Change History (22)
This ticket was mentioned in PR #455 on WordPress/wordpress-develop by musicaljoeker.
6 years ago
#1
#3
@
6 years ago
- Summary Social icons wrong color in Twenty Thirteen → Twenty Thirteen: Wrong color for social icons
#6
@
6 years ago
- Keywords commit added
- Owner set to
- Status new → accepted
the attached patch is working fine.
This ticket was mentioned in Slack in #core by helen. View the logs.
6 years ago
#10
@
6 years ago
Tested with WP 5.5.1 with and without Gutenberg 8.9.3.
Confirmed that the color problem is present and that the patch resolves it.
-There are small color differences to the links when this CSS is removed.
So the question is if this is something acceptable or if it needs to be solved.
The current colors are:
.entry-content a,
.comment-content a {
color: #bc360a;
}
.entry-content a:hover,
.comment-content a:hover {
color: #ea9629;
}
And when this code is removed the styles fall back to:
a {
color: #ca3c08;
text-decoration: none;
}
a:visited {
color: #ac0404;
}
a:focus {
outline: thin dotted;
}
a:active,
a:hover {
color: #ea9629;
outline: 0;
}
This ticket was mentioned in Slack in #core by sergey. View the logs.
6 years ago
hellofromtonya commented on PR #455:
6 years ago
#14
Merged in changeset https://core.trac.wordpress.org/changeset/49240.
hellofromtonya commented on PR #455:
6 years ago
#15
Merged in changeset https://core.trac.wordpress.org/changeset/49240.
Most link color should be set to the primary link color but not the
social icons. This change overrides the primary link colors of the links
colors in the theme to make social icons white to be contrasted by the
social link color in the pill behind.
Props: desrosj.
Fixes: 50809.
Trac ticket: