WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 6 months ago

Last modified 6 months ago

#50809 closed defect (bug) (fixed)

Twenty Thirteen: Wrong color for social icons

Reported by: desrosj Owned by: desrosj
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots good-first-bug has-patch commit
Focuses: Cc:

Description

When using the social block in Twenty Thirteen, the link colors are overridden.

This happens with all three block styles provided by default.

Attachments (7)

twenty thirteen social links.png (192.9 KB) - added by desrosj 9 months ago.
logos only.png (178.6 KB) - added by desrosj 9 months ago.
pill shape.png (185.6 KB) - added by desrosj 9 months ago.
50809.patch (504 bytes) - added by amolv 8 months ago.
Theme CSS removed which overwrites Social Icons Block CSS.
Social icons and link in content.png (122.8 KB) - added by amolv 8 months ago.
After CSS removal Social icons and link in page content looks good.
link-color.png (7.8 KB) - added by poena 7 months ago.
Current comment link color to the left, new color to the right
Screenshot 2020-10-20 110931.2.jpg (33.2 KB) - added by davidbaumwald 6 months ago.
Another test with the Block Editor

Download all attachments as: .zip

Change History (22)

@desrosj
9 months ago

@desrosj
9 months ago

This ticket was mentioned in PR #455 on WordPress/wordpress-develop by musicaljoeker.


8 months ago

Most link color should be set to the primary link color but not the
social icons. This change overrides the primary link colors of the links
colors in the theme to make social icons white to be contrasted by the
social link color in the pill behind.

Props: desrosj.
Fixes: 50809.

Trac ticket:

#2 @desrosj
8 months ago

  • Milestone changed from Awaiting Review to 5.6

#3 @SergeyBiryukov
8 months ago

  • Summary changed from Social icons wrong color in Twenty Thirteen to Twenty Thirteen: Wrong color for social icons

@amolv
8 months ago

Theme CSS removed which overwrites Social Icons Block CSS.

@amolv
8 months ago

After CSS removal Social icons and link in page content looks good.

#4 @amolv
8 months ago

  • Keywords has-patch added

#5 @Shital Patel
8 months ago

it works on my side

#6 @Shital Patel
8 months ago

  • Keywords commit added
  • Owner set to Shital Patel
  • Status changed from new to accepted

the attached patch is working fine.

#7 @desrosj
7 months ago

  • Owner changed from Shital Patel to desrosj
  • Status changed from accepted to assigned

This ticket was mentioned in Slack in #core by helen. View the logs.


7 months ago

#9 @helen
7 months ago

  • Keywords commit removed

#10 @poena
7 months ago

Tested with WP 5.5.1 with and without Gutenberg 8.9.3.

Confirmed that the color problem is present and that the patch resolves it.

-There are small color differences to the links when this CSS is removed.
So the question is if this is something acceptable or if it needs to be solved.

The current colors are:

.entry-content a,
.comment-content a {
	color: #bc360a;
}

.entry-content a:hover,
.comment-content a:hover {
	color: #ea9629;
}

And when this code is removed the styles fall back to:

a {
	color: #ca3c08;
	text-decoration: none;
}

a:visited {
	color: #ac0404;
}

a:focus {
	outline: thin dotted;
}

a:active,
a:hover {
	color: #ea9629;
	outline: 0;
}

@poena
7 months ago

Current comment link color to the left, new color to the right

This ticket was mentioned in Slack in #core by sergey. View the logs.


6 months ago

#12 @SergeyBiryukov
6 months ago

  • Keywords commit added

Marking for commit, per the latest comment.

@davidbaumwald
6 months ago

Another test with the Block Editor

#13 @desrosj
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49240:

Twenty Thirteen: Prevent incorrect link color within the Social Icon block.

Props amolv, shital-patel, poena, davidbaumwald.
Fixes #50809.

Note: See TracTickets for help on using tickets.