Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#50815 reviewing defect (bug)

Use consistent checks for displaying the Filter button in different list tables

Reported by: whyisjake's profile whyisjake Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Administration Keywords: needs-patch
Focuses: ui, administration, multisite Cc:


As an extension of #40188, let's bring some consistency to class-wp-posts-list-table.php and class-wp-ms-sites-list-table.php to check $this->has_items(), instead of ! empty( $output ).

Attachments (1)

50815.patch (1.1 KB) - added by mukesh27 4 years ago.
Initial patch.

Download all attachments as: .zip

Change History (12)

4 years ago

Initial patch.

#1 @mukesh27
4 years ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.6
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
4 years ago

In 48724:

Comments: Restore the ::has_items() call in WP_Comments_List_Table::extra_tablenav() for now, until unit tests are updated accordingly.

Follow-up to [48722].

Fixes #40188. See #50815.

#4 @SergeyBiryukov
4 years ago

Just to clarify on comment:23:ticket:40188, I didn't mean that ! empty( $output ) should necessarily be replaced with $this->has_items(), only that a consistent check should ideally be used in all list tables, whether it's the former, the latter, or both.

#5 @SergeyBiryukov
4 years ago

  • Summary changed from Use `$this->has_items()` for content checks in different list classes. to Use consistent checks for displaying the Filter button in different list tables

#6 @SergeyBiryukov
4 years ago

In 48741:

Comments: Remove a few more unnecessary instances of esc_html() in WP_Comments_List_Table::comment_status_dropdown().

Core translations are considered safe, and these labels are not escaped in any other instances.

Follow-up to [48521], [48722], [48724].

See #40188, #50815.

#7 @helen
4 years ago

Is anything left here?

#8 @SergeyBiryukov
4 years ago

  • Milestone changed from 5.6 to 5.7

comment:4:ticket:50815 still left to address, moving to the next release for now.

#9 @lukecarbis
3 years ago

  • Milestone changed from 5.7 to 5.8

Since we're in 5.7 beta 3, let's move this to the next release again.

This ticket was mentioned in Slack in #core by chaion07. View the logs.

3 years ago

#11 @hellofromTonya
3 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 5.8 to Future Release

Today is 5.8 Beta 1. Moving the last part of the ticket to Future Release as there's been no activity on it and it's been kicked down the road 2x already.

Note: See TracTickets for help on using tickets.