Opened 3 years ago
Closed 3 years ago
#50835 closed defect (bug) (fixed)
Return value DocBlock lacked attachment details for wp_prepare_attachment_for_js()
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | has-patch commit |
Focuses: | docs | Cc: |
Attachments (4)
Change History (13)
#2
@
3 years ago
- Milestone changed from Awaiting Review to 5.6
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core-media by antpb. View the logs.
3 years ago
#5
@
3 years ago
- Keywords needs-refresh removed
Hi there, I have refreshed the patch to get a proper alignment.
#7
@
3 years ago
- Keywords commit added
This is looking good. In 50835.4.diff I've made two changes:
- Ordered the block by the name of the property.
- Remove usage of the Saxon genitive, this is something we don't typically use in core although we're definitely not consistent about it.
Unless anyone objects to the latter, this is ready for commit.
Note: See
TracTickets for help on using
tickets.
It probably needs a refresh to fix the alignment, otherwise looks good.
Any thought @SergeyBiryukov?