#50837 closed defect (bug) (fixed)
Plugins installed outside of the plugin browser are showing an undefined index error
| Reported by: | sswebster | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.5 |
| Component: | Plugins | Version: | 5.5 |
| Severity: | normal | Keywords: | has-patch commit dev-reviewed |
| Cc: | Focuses: |
Description
When installing plugins outside of the WordPress plugin browser with debugging enabled, I'm receiving a "Notice: Undefined Index: Process_success_specific" error. This doesn't happen when installing a plugin through the plugin browser using ajax, but does happen if you install a plugin by navigating to the install URL. It looks to be related to an upgrader string added in this commit: https://github.com/WordPress/WordPress/commit/49bbff551ba5d8c6e9502835a9dcd466b6585406#diff-572613cbd6b420aa292bf4dab1a5f6e5
Attachments (1)
Change History (12)
This ticket was mentioned in PR #452 on WordPress/wordpress-develop by nateinaction.
6 years ago
#1
- Keywords has-patch added
This PR fixes an undefined index error that occurs when attempting to access the process_success_specific key. The fix prepopulates the WP_Upgrader->strings array, ensuring the process_success_specific key exists.
Trac ticket: https://core.trac.wordpress.org/ticket/50837
#5
follow-up:
↓ 6
@
6 years ago
Just noting that I was able to reproduce the issue, but it's not quite clear why this only happens for plugins and not for themes.
#6
in reply to: ↑ 5
@
6 years ago
Ah, it's because the Theme_Upgrader class has the string in the ::install_strings() method, while Plugin_Upgrader has it in ::upgrade_strings().
Moving the string to the correct method appears to resolve the issue.
#8
@
6 years ago
- Keywords commit dev-feedback added
- Resolution fixed
- Status closed → reopened
Reopening for the 5.5 branch.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Here is a screenshot of the issue when installing the Gutenberg plugin