[playlist] Please remove brackets from the titles

[hvar]

Dear developers,

the song titles should not be enclosed into "" brackets. They should be removed.

Every song name is appearing inside brackets, and it's not how songs should be represented. They are not fake titles, or presumably terms similar to the song titles - they are the actual song titles, they don't need the brackets. And also it looks really ugly.

Here is the corrected code from media.php:

Thank you

				<?php
					/* translators: %s: Playlist item title. */
					printf( _x( '%s', 'playlist item title' ), '{{{ data.title }}}' );
				?>
				</span>

[SergeyBiryukov]

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

Adjust the keywords per the ​workflow keywords used here on Trac.

[Presskopp]

patch according to the proposal

[sabernhardt]

removing quotation marks from title in both places, only when artist and album names do not appear

[sabernhardt]

Quotation marks usually would be around song titles in a paragraph, so it could make sense to keep them when the artist and/or album name display.

History: the quotes were added with playlist support in changeset:27239 (though r33643 replaced it with pseudo-elements in CSS and then r33844 converted it to translatable string).

[sabernhardt]

I made edits to both templates, but I do not know how to test the tmpl-wp-playlist-current-item template.

[James Roberts]

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/50865/50865.2.patch

Environment

• OS: macOS 12.4
• PHP: 7.4.33
• WordPress: 6.2-alpha-54642-src
• Browser: Chrome 107.0.5304.110 (Official Build) (arm64)
• Theme: Twenty Twenty-One, Twenty Twenty-Two, Twenty Twenty-Three

Results

• 'artists' attribute set as true - Quotation marks and artist name are visible on both the tracklist and the current track.
• 'artists' attribute set as false - Quotation marks and artist's name have been removed from the tracklist. The artist's name and quotation marks are still showing on the current track .wp-playlist-current-item.

[James Roberts]

Before patch 50865.2.patch

[James Roberts]

After patch 50865.2.patch

[James Roberts]

Before and after patch 50865.2.patch, with the "artists" attribute set to true

[arrasel403]

Hi

I need testing instructions, I want to help test this ticket. I couldn't find any playlist in Dashboard Media Library. Please share some testing information.

Thanks!

[sabernhardt]

For the current item, the quotes make enough sense with the album title. However, now I question whether they should stay there when the current track has an artist name but not an album title.

These instructions are probably not complete, but you could start with this:

1. Create a new post. If you are using the block editor, create a Classic block.
2. Click the Add Media button.
3. Upload at least two audio files. Set the Title, Artist and Album. (If you add more tracks, you could try some without an artist and/or album.)
4. Click "Create audio playlist" and select your items from the Media Library tab.
5. Click the "Create a new playlist" button.
6. Under Playlist Settings, you can choose "Show Artist Name in Tracklist" to test that option.
7. Click the "Insert audio playlist" button.
8. Create another playlist with the other option for Artist Name. (In the block editor, you may need to add this playlist within a separate Classic block.)

[abidhasan112]

Patch tested: https://core.trac.wordpress.org/attachment/ticket/50865/50865.2.patch

Environment

• OS: Windows 10
• Web Server: Apache
• PHP: 7.4.3
• WordPress: 6.2-alpha-55147
• Browser: Chrome 109.0.5414.120
• Theme: Twenty Twenty-Three

✅ Uploaded some audio files. Set the Title, Artist and Album.

Result:

✅ Under Playlist Settings, I can choose "Show Artist Name in Tracklist" option to test this feature.

Result:

✅ Frontend Result:

✅ Backend(Editor) Result:

[arrasel403]

Thanks for sharing the instructions.

Replying to sabernhardt:

For the current item, the quotes make enough sense with the album title. However, now I question whether they should stay there when the current track has an artist name but not an album title.

These instructions are probably not complete, but you could start with this:

1. Create a new post. If you are using the block editor, create a Classic block.
2. Click the Add Media button.
3. Upload at least two audio files. Set the Title, Artist and Album. (If you add more tracks, you could try some without an artist and/or album.)
4. Click "Create audio playlist" and select your items from the Media Library tab.
5. Click the "Create a new playlist" button.
6. Under Playlist Settings, you can choose "Show Artist Name in Tracklist" to test that option.
7. Click the "Insert audio playlist" button.
8. Create another playlist with the other option for Artist Name. (In the block editor, you may need to add this playlist within a separate Classic block.)

[arrasel403]

Test Report:

Patch tested: https://core.trac.wordpress.org/attachment/ticket/50865/50865.2.patch

Environment

• OS: macOS
• Web Server: nginx/1.23.2
• PHP: 7.4.33
• WordPress: 6.2-alpha-54642-src
• Browser: Chrome 109.0.5414.87
• Theme: Twenty Twenty-Three

Result

✅ Upload Audio files and set Title, Artist Name and Album Name. ​https://prnt.sc/vcI7SNsjzq_d

✅ Before Applying the patch, the Artist attribute is set as TRUE and another one is set as FALSE and getting like this screenshot: ​https://prnt.sc/iNmHZC2IX163

✅ After Applying the patch, the Artist attribute is set as TRUE and another one is set as FALSE and getting like this screenshot: ​https://prnt.sc/8PoDJqDVZ-JG

[robinwpdeveloper]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/50865/50865.2.patch

Environment

• OS: macOS 11.2.3 (20D91)
• Web Server: Nginx
• PHP: 7.4.30
• WordPress: 6.2-alpha-54642-src
• Browser: Chrome 109.0.5414.119
• Theme: Twenty Twenty-Three
• Active Plugins:
  • No plugins activated

Actual Results

• ✅ Issue resolved with patch.

Additional Notes

After applying the patch:

• With Artist name: quotes found
• Without Artist name: quotes removed

Supplemental Artifacts

Before: ​https://d.pr/i/ZoMGqP
After: ​https://d.pr/i/8DSeen

[costdev]

This ticket was discussed in the bug scrub. As this has several successful test reports and the patch looks clean, I'm removing needs-testing and adding for commit consideration.

Additional props to @mukesh27

[audrasjb]

Self assigning for commit as today is 6.2 beta 1 release day.

[audrasjb]

In 55251:

Media: Remove unwanted quotation marks for playlist template.

This changeset improves the way quotation marks are handled in the Playlist template.

Follow-up to [27239], [33643 ].

Props hvar, Presskopp, sabernhardt, james-roberts, arrasel403, abidhasan112, robinwpdeveloper, costdev, mukesh27.
Fixes #50865.