Correct usage of the non-dynamic auto_update_plugin and auto_update_theme hooks

[johnbillion]

The auto_update_plugin and auto_update_theme hooks are used in a few places in core, but the canonical name for both of these is "auto_update_{$type}". This means the corresponding comment above each one is not correct.

We should change these instances to the dynamic name so the developer reference site remains correct.

In addition, this is a filter not an action so the comments need updating in a few places.

Milestoning for 5.5 so we ensure all the docs are as accurate as possible now that user-controllable plugin and theme auto updates are a feature.

[johnbillion]

Patch that also updates the docs for the "auto_update_{$type}" filter to add a full version of the possible filter names, which means that searching the Developer Reference site for any of those filter names will return this filter in the search results.

[johnbillion]

This needs testing to ensure the $type variable isn't overwriting one that already exists.

[SergeyBiryukov]

Looking at the patch, this would probably benefit from having a dedicated function as a wrapper for the filter, e.g. wp_is_auto_update_forced_for_type(), similar to wp_is_auto_update_enabled_for_type().

But that's something for a future release, 50868.diff​ should be fine for now. Haven't tested yet though, working on that now.

[SergeyBiryukov]

As far as I can tell, the $type variable doesn't clash with any existing ones. Should be good to go.

[SergeyBiryukov]

In 48750:

Docs: Correct usage of the dynamic auto_update_{$type} filter.

This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.

Props johnbillion.
Fixes #50868.

[SergeyBiryukov]

Reopening for the 5.5 branch.

[SergeyBiryukov]

Replying to SergeyBiryukov:

Looking at the patch, this would probably benefit from having a dedicated function as a wrapper for the filter, e.g. wp_is_auto_update_forced_for_type(), similar to wp_is_auto_update_enabled_for_type().

Follow-up: #50875

[whyisjake]

In 48756:

Docs: Correct usage of the dynamic auto_update_{$type} filter.

This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.

This brings the changes from [48750] to the 5.5 branch.

Props johnbillion.
Fixes #50868, see [48750].