#50892 closed defect (bug) (fixed)
Some block patterns have text contrast issues with dark themes
| Reported by: | nrqsnchz | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.5.1 |
| Component: | Editor | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
Moving from https://github.com/WordPress/gutenberg/issues/24391
Some block patterns are presenting text contrast issues on dark themes. The patterns with the issue are:
- Two columns of text
- Two columns of text with images
- Three columns of text with buttons
- Heading and Paragraph
These patterns have the text color of body copy hardcoded to black, which causes the aforementioned issues when viewed on a dark theme.
Attachments (9)
Change History (17)
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
6 years ago
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
I've uploaded a patch with a fix. It removes the hardcoded value only from body text. Patterns should now respect the theme's default text color.
I also tested on Core default themes (from Twenty Ten to Twenty Twenty) and couldn't see any issues there due to this change.