#50892 closed defect (bug) (fixed)
Some block patterns have text contrast issues with dark themes
Reported by: | nrqsnchz | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Moving from https://github.com/WordPress/gutenberg/issues/24391
Some block patterns are presenting text contrast issues on dark themes. The patterns with the issue are:
- Two columns of text
- Two columns of text with images
- Three columns of text with buttons
- Heading and Paragraph
These patterns have the text color of body copy hardcoded to black, which causes the aforementioned issues when viewed on a dark theme.
Attachments (9)
Change History (17)
Note: See
TracTickets for help on using
tickets.
I've uploaded a patch with a fix. It removes the hardcoded value only from body text. Patterns should now respect the theme's default text color.
I also tested on Core default themes (from Twenty Ten to Twenty Twenty) and couldn't see any issues there due to this change.