WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50896


Ignore:
Timestamp:
08/11/2020 03:28:03 PM (10 months ago)
Author:
SergeyBiryukov
Comment:

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

When first introduced and described on the Make blog by Yoast, the function contained filters. These filters were removed in [48662] because "the function is called too early for any plugins to properly hook into these filters". ... Reverting [48662] would close this ticket.

Just noting that simply reverting [48662] won't work as expected. As previously noted in comment:58:ticket:33161, the result of the function is cached into a static variable (per comment:44:ticket:33161) on the first run (which is too early for filters), and cannot be changed later.

So we'll also have to remove the static variable, which may lead to issues, as noted in comment:44:ticket:33161.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50896 – Description

    initial v1  
    55In my case, I want to set the default environment to "development": while there's only one production environment, there are multiple development environments that can be created at any time. Setting the environment default to "development" means that whenever a new development environment is created, the code runs in its safest mode from the start, even without explicitly defining `WP_ENVIRONMENT_TYPE` constant.
    66
    7 Reverting [https://core.trac.wordpress.org/changeset/48662 48662] would close this ticket.
     7Reverting [48662] would close this ticket.