PHP 8: fix final private methods

[jrf]

Declaring a private method as final is an oxymoron, as private methods cannot be overloaded anyway.

Using final private function... will generate a warning in PHP 8.

The attached patch fixes all known instances of this in WP Core at the time of writing.

Declaring a private method as final is an oxymoron, as private methods cannot be overloaded anyway.

This will generate a warning in PHP 8.

Trac ticket: https://core.trac.wordpress.org/ticket/50897

[SergeyBiryukov]

In 48788:

Code Modernization: Remove final keyword from private methods.

Declaring a private method as final is an oxymoron, as private methods cannot be overloaded anyway.

Using final private function... will generate a warning in PHP 8.

Props jrf.
Fixes #50897.

Patch has been committed. Closing.

[desrosj]

Adding needs-dev-note to include in the PHP 8 developer note.

[daisyo]

Dev note published: ​https://make.wordpress.org/core/2020/11/23/wordpress-and-php-8-0/