Opened 4 years ago
Closed 4 years ago
#50903 closed enhancement (fixed)
Set the local environment to a development environment type by default
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.5.2 | Priority: | normal |
Severity: | normal | Version: | 5.5 |
Component: | Build/Test Tools | Keywords: | good-first-bug has-patch has-screenshots fixed-major |
Focuses: | Cc: |
Description
Follow-up to #33161.
The local Docker-based environment should populate the WP_ENVIRONMENT_TYPE
constant with a value of development
by default.
See tools/local-env/scripts/install.js
.
Attachments (1)
Change History (17)
This ticket was mentioned in PR #543 on WordPress/wordpress-develop by igorradovanov.
4 years ago
#4
- Keywords has-patch added; needs-patch removed
This change populates the new WP_ENVIRONMENT_TYPE
variable for the local development environment with the value of 'development' using the WordPress CLI.
Trac ticket: https://core.trac.wordpress.org/ticket/50903
#5
in reply to:
↑ 3
@
4 years ago
Replying to johnbillion:
@igorradovanov Yes! Please feel free to go ahead.
Thanks, John.
Just submitted the first patch via the GitHub mirror.
TimothyBJacobs commented on PR #543:
4 years ago
#6
We have a local environment type now that we could use instead. https://core.trac.wordpress.org/ticket/51064
igorradovanov commented on PR #543:
4 years ago
#7
@TimothyBJacobs I agree with you that 'local' would be a better env type in this case. Let's see what @johnbillion thinks of this since the trac was originally raised to set the value to 'development'.
johnbillion commented on PR #543:
4 years ago
#8
Yeah local
would be better, thanks for pointing that out.
igorradovanov commented on PR #543:
4 years ago
#9
Thanks Timothy and John.
The latest patch has been applied. Travis CI is running the checks.
Switched development
to local
in the .env file.
#10
@
4 years ago
- Milestone changed from Future Release to 5.6
- Owner set to johnbillion
- Status changed from new to accepted
dream-encode commented on PR #543:
4 years ago
#13
Merged into WP Core in https://core.trac.wordpress.org/changeset/49121
Hi @johnbillion,
Is this issue still open?
I would like to work on this one.