WordPress.org

Make WordPress Core

#50903 closed enhancement (fixed)

Set the local environment to a development environment type by default

Reported by: johnbillion Owned by: johnbillion
Milestone: 5.5.2 Priority: normal
Severity: normal Version: 5.5
Component: Build/Test Tools Keywords: good-first-bug has-patch has-screenshots fixed-major
Focuses: Cc:

Description

Follow-up to #33161.

The local Docker-based environment should populate the WP_ENVIRONMENT_TYPE constant with a value of development by default.

See tools/local-env/scripts/install.js.

Attachments (1)

Screenshot 2020-10-10 at 22.08.54.png (21.1 KB) - added by johnbillion 12 months ago.

Download all attachments as: .zip

Change History (17)

#1 @johnbillion
13 months ago

  • Keywords good-first-bug added

#2 @igorradovanov
12 months ago

Hi @johnbillion,

Is this issue still open?

I would like to work on this one.

#3 follow-up: @johnbillion
12 months ago

@igorradovanov Yes! Please feel free to go ahead.

This ticket was mentioned in PR #543 on WordPress/wordpress-develop by igorradovanov.


12 months ago

  • Keywords has-patch added; needs-patch removed

This change populates the new WP_ENVIRONMENT_TYPE variable for the local development environment with the value of 'development' using the WordPress CLI.

Trac ticket: https://core.trac.wordpress.org/ticket/50903

#5 in reply to: ↑ 3 @igorradovanov
12 months ago

Replying to johnbillion:

@igorradovanov Yes! Please feel free to go ahead.

Thanks, John.

Just submitted the first patch via the GitHub mirror.

#6 @prbot
12 months ago

TimothyBJacobs commented on PR #543:

We have a local environment type now that we could use instead. https://core.trac.wordpress.org/ticket/51064

#7 @prbot
12 months ago

igorradovanov commented on PR #543:

@TimothyBJacobs I agree with you that 'local' would be a better env type in this case. Let's see what @johnbillion thinks of this since the trac was originally raised to set the value to 'development'.

#8 @prbot
12 months ago

johnbillion commented on PR #543:

Yeah local would be better, thanks for pointing that out.

#9 @prbot
12 months ago

igorradovanov commented on PR #543:

Thanks Timothy and John.

The latest patch has been applied. Travis CI is running the checks.

Switched development to local in the .env file.

#10 @johnbillion
12 months ago

  • Milestone changed from Future Release to 5.6
  • Owner set to johnbillion
  • Status changed from new to accepted

#11 @johnbillion
12 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49121:

Build/Test Tools: Set the local development environment to a local environment type by default.

Props igorradovanov, TimothyBlynJacobs

Fixes #50903

See #33161

#12 @johnbillion
12 months ago

  • Keywords has-screenshots added

#14 @desrosj
11 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.6 to 5.5.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

This should be backported to the 5.5 branch, since environment type was added in that version.

#15 @desrosj
11 months ago

In 49339:

Build/Test Tools: Set the local development environment to a local environment type by default.

Props igorradovanov, TimothyBlynJacobs, johnbillion.
Merges [49121] to the 5.5 branch.
See #50903.

#16 @desrosj
11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.