Site Health flags define WP_AUTO_UPDATE_CORE value as an error

[sterndata]

See ​https://wordpress.org/support/topic/wp_auto_update_core-2

If this is in wp-config.php:

define('WP_AUTO_UPDATE_CORE', 'minor')

Site health reports

Error The WP_AUTO_UPDATE_CORE constant is defined and enabled.

According to the docs, 'minor' is a legit value for the constant.

Note that changeset [47841] changed it from loose to a strict comparison...

[SergeyBiryukov]

Hi there, thanks for the ticket!

At a glance, this seemed like a duplicate of #49923. Upon a closer look, however, that ticket is about the message displayed when WP_AUTO_UPDATE_CORE is set to false, and this one is about the value set to 'minor'.

Indeed it looks like before [47841], 'minor' was recognized as a valid value, due to a loose comparison with true. With the strict comparison, it's no longer recognized.

[sterndata]

I referred to the docs, so: ​https://wordpress.org/support/article/configuring-automatic-background-updates/#constant-to-configure-core-updates

[mukesh27]

Below both give same result in site health report.

if ( defined( $constant ) && constant( $constant ) != $value ) { and if ( defined( $constant ) && constant( $constant ) !== $value ) {

Both give same result - The WP_AUTO_UPDATE_CORE constant is defined and enabled.

[avixansa]

So for the time being , i removed this line define('WP_AUTO_UPDATE_CORE', 'minor') from the config file and the site health is not showing this issue any more !!

1. But is it recommended ?
2. Also After doing that ..

I see a new column and a constant checking of the update in the plugin page !!
​http://prnt.sc/tyekx6

[desrosj]

@avixansa WP_AUTO_UPDATE_CORE is used to configure the types of WordPress updates that you'd like to receive automatically. In your case, you were specifying minor updates (updates to the Z number in X.Y.Z).

This is actually the default behavior of WordPress Core. So you can safely remove that constant and should not see any problems or changes in behavior.

The new column that you are seeing on the plugin page is a feature added in 5.5, so it looks like your site updated correctly.

However, sometimes it is desired to define WP_AUTO_UPDATE_CORE as minor, so the issue described here and expanded by @SergeyBiryukov above should still be fixed.

[SergeyBiryukov]

In 48792:

Site Health: Recognize define( 'WP_AUTO_UPDATE_CORE', 'minor' ) as an acceptable value.

Previously, it was only incidentally recognized as valid due to a loose comparison with true.

With the strict comparison added to WP_Site_Health_Auto_Updates::test_constants(), this was no longer the case.

Follow-up to [47841].

Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Fixes #50912.

[SergeyBiryukov]

Reopening for the 5.5 branch.

[SergeyBiryukov]

In 48804:

Site Health: Recognize define( 'WP_AUTO_UPDATE_CORE', 'minor' ) as an acceptable value.

Previously, it was only incidentally recognized as valid due to a loose comparison with true.

With the strict comparison added to WP_Site_Health_Auto_Updates::test_constants(), this was no longer the case.

Follow-up to [47841].

Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Merges [48792] to the 5.5 branch.
Fixes #50912.