WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

Last modified 2 months ago

#50945 closed enhancement (fixed)

Site Health: don't give a warning when upload_max_size is lower than max_post_size

Reported by: jeroenrotty Owned by: SergeyBiryukov
Milestone: 5.5.1 Priority: normal
Severity: normal Version: 5.5
Component: Site Health Keywords: good-first-bug has-patch commit fixed-major i18n-change
Focuses: Cc:

Description

Site Health component added a new check in version 5.5 where post_max_size differs from upload_max_size which can lead to upload issues.

However, there is no need to show a warning/error if post_max_size is a higher value than upload_max_size. In a current site I maintain, post_max_size is 8M and the max_upload_size is 2M and the Improvement is shown.

Also, the copy might need to be reviewed, as we literally say that the values differ and *that* is the issue.

Attachments (1)

50945.diff (1.3 KB) - added by oakesjosh 2 months ago.

Download all attachments as: .zip

Change History (12)

#1 @Clorith
3 months ago

  • Milestone changed from Awaiting Review to 5.5.1

#2 @desrosj
3 months ago

  • Keywords needs-patch good-first-bug added

Introduced in [48535] and adjusted in [48538-48539,48544] (see #50038).

@oakesjosh
2 months ago

#3 @oakesjosh
2 months ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @Clorith
2 months ago

#51032 was marked as a duplicate.

#6 @Clorith
2 months ago

  • Keywords commit added

The attached patch in 50945.diff is spot on, and makes this report much more accurate.

#7 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48800:

Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize.

Previously, the warning was displayed even if the value was higher than upload_max_filesize, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Fixes #50945.

#8 @SergeyBiryukov
2 months ago

In 48801:

Site Health: Rename the $upload_max_size variable to $upload_max_filesize, for consistency with the PHP setting name.

Follow-up to [48535], [48538], [48539], [48544], [48800].

See #50945.

#9 @SergeyBiryukov
2 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for the 5.5 branch.

#10 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 48806:

Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize.

Previously, the warning was displayed even if the value was higher than upload_max_filesize, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Merges [48800] and [48801] to the 5.5 branch.
Fixes #50945.

#11 @SergeyBiryukov
2 months ago

  • Keywords i18n-change added
Note: See TracTickets for help on using tickets.