media_handle_sideload() does not allow $post_data to override the post_date that gets used by wp_upload_dir

[jamesgol]

Now that $post_id is an optional attribute to media_handle_sideload() it should be possible to override the $time passed to wp_handle_sideload() via the optional $post_data array.

My use case is calling media_handle_sideload() via a custom plugin, only after the existing library is checked for duplicates is the post actually created so there is no $post_id to reference (yet).

[mukesh27]

#50971 was marked as a duplicate.

[mukesh27]

Hi there!

isset( $post_data ) value is always true when it was empty array or non empty array.

Update the patch without checking it.

[mukesh27]

Updated patch.

[jamesgol]

I always assume that someone's going to do something wrong like try to pass in null or false as an argument. So in my opinion it's safer to at least check. One step further would be a check for is_array().

[antpb]

It was mentioned in the recent Media meeting that the sideloading functions could benefit from a refactor to allow testing as it is currently hard to test the same way that media_sideload_image was and did not receive tests.

Being so late in beta cycle it's probably best to move this out of the 5.6 milestone. If anyone feels differently please feel free to move it back in.