WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50992, comment 31


Ignore:
Timestamp:
08/29/2020 05:16:40 PM (3 months ago)
Author:
giuseppe.mazzapica
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50992, comment 31

    initial v1  
    66Now I need to change the workflow again. I can't use a database because the first check happens before WP is loaded, I'll probably revert back to my own environment management.
    77
    8 My point is that when support for a constant is added, it should not be removed in a** bugfix release** that, as you know, might happen to be pushed overnight on environments via automatic updates.
     8My point is that when support for a constant is added, it should not be removed in a **point release** that, as you know, might happen to be pushed overnight on environments via automatic updates.
    99
    10 I see you added a deprecation notice if WP_ENVIRONMENT_TYPES is defined, why not _just_ keep this notice and wait at list next minor to remove support?
     10I see you added a deprecation notice if WP_ENVIRONMENT_TYPES is defined, why not ''just'' keep this notice and wait at list next major to remove support?
    1111
    12 Is not that the point of deprecation notices? First you deprecate, in next version you remove. Or am I wrong?
     12Is not that the point of deprecation notices? First, you deprecate, in the next version you remove. Or am I wrong?
    1313
    14 But I guess is too late now.
     14But I guess it's too late now.
    1515