WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50999, comment 10


Ignore:
Timestamp:
08/20/2020 02:08:49 PM (13 months ago)
Author:
sageshilling
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50999, comment 10

    initial v1  
    1 Replying to [comment:3 mikeyarce]:
    2 > Thanks for the report @herregroen ! 
    3 >
    4 > Does your patch remove all the concatenation for all scripts though?
    5 >
    6 > I wanted to note that a side-effect of the concatenation change in 5.5 is that now that `media-editor.js` is being concatenated (looks like it wasn't in 5.4 by default?), it's causing some issues when using another concat plugin in conjunction like: https://github.com/Automattic/nginx-http-concat/
    7 >
    8 > The patch in this ticket does fix our problems though because it removes things like `media-editor.js` from being concatenated.
    91
    10 >there are ids & widths...possibly by updating the js would work.  using var variablename for concatenation, basically updating code
    11 >
    12 > I'm curious about the reasoning to start concatenating `media-editor.js` and other scripts like that and if we're seeing other problems like the one I mentioned.