WordPress.org

Make WordPress Core

#51002 closed defect (bug) (worksforme)

Remove space from left and right side and make full with section on the About page.

Reported by: Laxman Prajapati Owned by: audrasjb
Milestone: Priority: normal
Severity: normal Version: 5.6
Component: Help/About Keywords:
Focuses: ui Cc:

Description

On the about.php there used "has-1-column" class for 1 column on the "Speed", "Search", "Accessibility" sections. But on the same class have used "max-width: 36em;" CSS so for this reason the much space is black on the left and right side.
So from the "Speed", "Search", "Accessibility" sections should be removed the "has-1-column" class name.

Attachments (2)

about.php (14.5 KB) - added by Laxman Prajapati 13 months ago.
Remove space from left and right side and make full with section on the About page.
Capture d’écran 2020-08-14 à 19.10.08.png (112.4 KB) - added by audrasjb 13 months ago.
Without has-1-column

Download all attachments as: .zip

Change History (9)

@Laxman Prajapati
13 months ago

Remove space from left and right side and make full with section on the About page.

#1 @Laxman Prajapati
13 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
13 months ago

  • Component changed from General to Help/About
  • Milestone changed from Awaiting Review to 5.5.1

#3 follow-up: @SergeyBiryukov
13 months ago

  • Keywords has-patch removed

Hi there, welcome to WordPress Trac! Thanks for the ticket.

I'm removing the has-patch tag for now, as about.php is not a patch that can be applied.

Please see the Submitting a Patch handbook article if you'd like to create a patch.

Last edited 13 months ago by SergeyBiryukov (previous) (diff)

#4 in reply to: ↑ 3 @Laxman Prajapati
13 months ago

Okay. Now we need to add patch? OR uploaded about.php file ok for you? Because We have implemented on the about.php file and uploaded it.

Replying to SergeyBiryukov:

Hi there, welcome to WordPress Trac! Thanks for the ticket.

I'm removing the has-patch tag for now, as about.php is not a patch that can be applied.

Please see the Submitting a Patch handbook article if you'd like to create a patch.

Last edited 13 months ago by Laxman Prajapati (previous) (diff)

@audrasjb
13 months ago

Without has-1-column

#5 follow-up: @audrasjb
13 months ago

  • Keywords close reporter-feedback added
  • Owner set to audrasjb
  • Status changed from new to assigned

Hi @laxman-prajapati, welcome to WordPress Trac and thank you for this ticket,

I understand your request but this class was added on purpose by the team who designed this page. I don't think this change solves any bug or issue, other than making it better for those who personally don't like this design :-)

Can you report any issue other than "I dont like it"? :)
We need some more rationale reasons to remove the class (something like "it's broken on small devices", for example).

Thank you,
Jb

#6 in reply to: ↑ 5 @Laxman Prajapati
13 months ago

Actually I was see the blank space on the left and right side. So for this reason i have created ticket.

No problem.

Thank you.

Replying to audrasjb:

Hi @laxman-prajapati, welcome to WordPress Trac and thank you for this ticket,

I understand your request but this class was added on purpose by the team who designed this page. I don't think this change solves any bug or issue, other than making it better for those who personally don't like this design :-)

Can you report any issue other than "I dont like it"? :)
We need some more rationale reasons to remove the class (something like "it's broken on small devices", for example).

Thank you,
Jb

#7 @audrasjb
13 months ago

  • Keywords close reporter-feedback removed
  • Milestone 5.5.1 deleted
  • Resolution set to worksforme
  • Status changed from assigned to closed

Thank you for confirming @laxman-prajapati :)

Note: See TracTickets for help on using tickets.